From Alex in #1608842: Replace list of bootstrap modules, enabled modules, enabled themes, and default theme with config....

+++ b/core/includes/install.inc
@@ -418,20 +409,15 @@ function drupal_install_system() {
+ config('system.module')
+ ->set('system', 0)

My first impression reading this was that we were disabling system.module, but what's actually happening here is we're enabling it with a weight of 0. Similarly, looking at the generated system.module.yml file, seeing a bunch of MODULE_NAME: 0 lines doesn't tell me the 0s are weights. Any reason not to change this to set('system.weight', 0)?

Comments

alexpott’s picture

Status: Active » Closed (won't fix)

Doing this would result in a system.module file looking like this:

enabled:
  block:
    weight: -5
  dblog:
    weight: 0
  entity:
    weight: 0
  field:
    weight: 0
  file:
    weight: 0
  filter:
    weight: 0
  menu_link:
    weight: 0
  node:
    weight: 0
  simpletest:
    weight: 0
  system:
    weight: 0
  text:
    weight: 0
  update:
    weight: 0
  user:
    weight: 0
  minimal:
    weight: 1000

Perhaps we can improve the comment here to explain what is going on. But I'm inclined to won't fix.