A new translations:// directory was recently created in #1658842: Introduce a translations:// stream wrapper to access the .po file directory. In the simpletest framework we create new directories for public://, private:// and temporary://. We should do the same for translations:// to ensure that tests run in a clean environment.
Without this I experience some strange interdependencies between the "Translation export" and "String translate, search and validate" (but only with my patch for #1393392: Convert prefix cache clears to cache tags, then remove support for them - I'm not sure why).
Comment | File | Size | Author |
---|---|---|---|
#5 | translations-simpletest-4.patch | 6.03 KB | c960657 |
#3 | translations-simpletest-3.patch | 1.97 KB | c960657 |
translations-simpletest-1.patch | 1.97 KB | c960657 | |
Comments
Comment #1
penyaskitoTagging for catching more attention.
Comment #2
penyaskitoIMHO, if this is set at the TestBase class, we should remove any additional set up of this directory in LocaleExportTest and LocaleFileImportStatus at least (writing from the top of my head, maybe it's referenced in other tests too).
Otherwise, make sense to have some consistence here.
Comment #3
c960657 CreditAttribution: c960657 commentedAgreed. I removed the file_prepare_directory() calls from the locale tests.
BTW, doesn't this line-up indicate an inconsistency in the naming of these variables?
Comment #4
attiks CreditAttribution: attiks commentedIsn't the patch in #3 the same as the original one?
Comment #5
c960657 CreditAttribution: c960657 commentedOops, try this one instead.
Comment #6
attiks CreditAttribution: attiks commentedNice work. Is looking good to me, RTBC, but would love to see another +1 by penyaskito and/or Gabor.
Comment #7
chx CreditAttribution: chx commentedThanks for fixing this -- and I think I haven't you see in a while -- c960657 , welcome back!
Comment #8
c960657 CreditAttribution: c960657 commentedThanks! I haven't really been away, but I have been running on low steam for quite some time. But recently my addiction has come back :-)
Comment #9
Gábor HojtsyLooks good to me.
Comment #10
webchickLooks straight-forward. Nice to see you "addicted" again, c960657! :)
Committed and pushed to 8.x. Thanks!
Comment #11
Gábor HojtsySuperb, thanks all!