Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The docs in bootstrap.inc are not 100% documented, let's fix that.
This patch is far from complete.
Comment | File | Size | Author |
---|---|---|---|
#10 | language_function_docs-1739592-10.patch | 846 bytes | Albert Volkman |
#7 | language_function_docs-1739592-7.patch | 3.44 KB | Albert Volkman |
#7 | interdiff.txt | 1.37 KB | Albert Volkman |
#5 | language_function_docs-1739592-5.patch | 3.43 KB | Albert Volkman |
#5 | interdiff.txt | 512 bytes | Albert Volkman |
Comments
Comment #1
funex CreditAttribution: funex commentedAdded documentation to language_is_locked() and checked other language functions documentation.
Comment #2
FelixH CreditAttribution: FelixH commentedIm gonna review the patch.
Comment #3
FelixH CreditAttribution: FelixH commentedTested if Patch does only modify commented parts.
Patch reviewed. Patch works and may be applied. Improving Docs may also be continued.
Comment #4
catchIf it returns bool, shouldn't it return TRUE if more than one language instead of 1?
Comment #5
Albert Volkman CreditAttribution: Albert Volkman commentedChanged per @catch's suggestion. Also added missing space before @return.
Comment #6
Gábor HojtsyShould this be a sentence instead? ie. "is enabled" is missing at the end.
Are we using lowercase FALSE when documenting return types? We use it uppercase in all other cases?!
Comment #7
Albert Volkman CreditAttribution: Albert Volkman commentedFixed those issues, and found a comment that was > 80 chars.
Comment #8
Gábor HojtsyLooks good to me, let's place it with the docs component, so Jennifer will see it directly. Thanks all!
Comment #9
jhodgdonCommitted to 8.x. I'm undecided on backporting to 7.x... for the most part we don't have return/param types in 7.x at all, and some of the types here would not be right for 7.x anyway... but some of this patch could be useful maybe?
Comment #10
Albert Volkman CreditAttribution: Albert Volkman commentedYeah, a couple of hunks are still applicable.
Comment #11
Albert Volkman CreditAttribution: Albert Volkman commentedComment #12
jhodgdonThanks -- that patch is committed to 7.x.