See #1711070: Convert tests to use ::$modules property instead of parent::setUp($modules).

CommentFileSizeAuthor
#6 profiles-1711436-6.patch1.57 KBxjm
#6 interdiff-6.txt1.13 KBxjm
#5 profiles-1711436-5.patch1.57 KBxjm
#5 interdiff.txt1.14 KBxjm
#3 drupal-1711436-3.patch1.48 KBtim.plunkett
#1 drupal-1711436-1.patch1.45 KBtim.plunkett
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Active » Needs review
FileSize
drupal-1711436-1.patch1.45 KB

See attached.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Status: Needs review » Needs work

See the summary of #1711070: Convert tests to use ::$modules property instead of parent::setUp($modules) for the docblocks that should be added. Also, the current docblock does not match our standards. We could probably trim it down to fit on one line and make it clearer in the process. :)

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs work » Needs review
FileSize
drupal-1711436-3.patch1.48 KB

I think its a fine comment, when moved to the middle of a docblock like you mentioned.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented

Well, it's missing an article (the testing profile), and the comma before "while" is not grammatical. It also doesn't quite make sense. It sounds like it's been translated from German or Dutch. :)

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
FileSize
interdiff.txt1.14 KB
profiles-1711436-5.patch1.57 KB

This is a little clearer I think.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
FileSize
interdiff-6.txt1.13 KB
profiles-1711436-6.patch1.57 KB

Er, and with the wrapping fixed.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs review » Reviewed & tested by the community

Ah, that does make more sense. :)

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Reviewed & tested by the community » Closed (duplicate)