Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim.plunkett’s picture

Assigned: Unassigned » tim.plunkett
tim.plunkett’s picture

Status: Active » Needs review
FileSize
9.04 KB

Woo!

xjm’s picture

Status: Needs review » Needs work

See the summary of #1711070: Convert tests to use ::$modules property instead of parent::setUp($modules) for the docblocks that should be added.

tim.plunkett’s picture

Status: Needs work » Needs review
FileSize
9.72 KB

Rerolled

xjm’s picture

+++ b/core/modules/user/lib/Drupal/user/Tests/UserPictureTest.phpundefined
@@ -22,7 +30,7 @@ class UserPictureTest extends WebTestBase {
   function setUp() {
-    parent::setUp(array('image'));
+    parent::setUp();
     // Enable user pictures.

+++ b/core/modules/user/lib/Drupal/user/Tests/UserValidateCurrentPassCustomFormTest.phpundefined
@@ -33,7 +40,7 @@ class UserValidateCurrentPassCustomFormTest extends WebTestBase {
   function setUp() {
-    parent::setUp('user_form_test');
+    parent::setUp();
     // Create two users

Do we want a blank line after the setup and before the inline comment (as in the other patches)?

Albert Volkman’s picture

Now with more spaces.

tim.plunkett’s picture

Status: Needs review » Needs work
+++ b/core/modules/user/lib/Drupal/user/Tests/UserLanguageCreationTest.phpundefined
@@ -23,7 +30,7 @@ class UserLanguageCreationTest extends WebTestBase {
+    parent::setUp();
     variable_set('user_register', USER_REGISTER_VISITORS);

Still missing the newline?

Albert Volkman’s picture

Status: Needs work » Needs review
FileSize
9.72 KB
tim.plunkett’s picture

Status: Needs review » Reviewed & tested by the community

Looks good. Thanks for cleaning that up!

ZenDoodles’s picture

Status: Reviewed & tested by the community » Closed (duplicate)

Now that timplunkett rolled them into one, this is a duplicate of the parent issue: #1711070: Convert tests to use ::$modules property instead of parent::setUp($modules)