See #1711070: Convert tests to use ::$modules property instead of parent::setUp($modules).

CommentFileSizeAuthor
#8 taxonomy-rdf-combined.patch12.96 KBtim.plunkett
#3 taxonomy-1711426-3.patch5.65 KBxjm
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Assigned: Unassigned » xjm
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented 
[lorentz:taxonomy | Sun 13:01:03] $ grep -nr "parent::setUp([^)]" * 
lib/Drupal/taxonomy/Tests/HooksTest.php:24:    parent::setUp(array('taxonomy_test'));
lib/Drupal/taxonomy/Tests/RssTest.php:24:    parent::setUp(array('node', 'field_ui'));
lib/Drupal/taxonomy/Tests/TaxonomyTestBase.php:23:    parent::setUp($modules);
lib/Drupal/taxonomy/Tests/TermFieldMultipleVocabularyTest.php:28:    parent::setUp('field_test');
lib/Drupal/taxonomy/Tests/TermFieldTest.php:29:    parent::setUp('field_test');
lib/Drupal/taxonomy/Tests/VocabularyUnitTest.php:24:    parent::setUp(array('field_test'));
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Status: Active » Needs review
FileSize
taxonomy-1711426-3.patch5.65 KB

Status: Needs review » Needs work
Issue tags: -Novice, -Testing system

The last submitted patch, taxonomy-1711426-3.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs work » Needs review

#3: taxonomy-1711426-3.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Novice, +Testing system

The last submitted patch, taxonomy-1711426-3.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs work » Postponed

I just figured out why this is failing: Drupal\rdf\Tests\MappingDefinitionTest extends Drupal\taxonomy\Tests\TaxonomyTestBase. So this needs to be postponed on #1711408: Convert rdf tests to use ::$modules property instead of parent::setUp($modules)

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Postponed » Needs review
FileSize
taxonomy-rdf-combined.patch12.96 KB

Just to make sure there's nothing else at play here, combining the two patches.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs review » Postponed
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Postponed » Closed (duplicate)
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Assigned: xjm » Unassigned