It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.
See #1711070: Convert tests to use ::$modules property instead of parent::setUp($modules).
[lorentz:search | Fri 11:04:38] $ grep -nr "parent::setUp([^)]" * lib/Drupal/search/Tests/SearchBlockTest.php:20: parent::setUp(array('block')); lib/Drupal/search/Tests/SearchCommentCountToggleTest.php:36: parent::setUp(array('comment')); lib/Drupal/search/Tests/SearchCommentTest.php:27: parent::setUp(array('comment')); lib/Drupal/search/Tests/SearchConfigSettingsFormTest.php:26: parent::setUp(array('block', 'search_extra_type')); lib/Drupal/search/Tests/SearchEmbedFormTest.php:33: parent::setUp(array('search_embedded_form')); lib/Drupal/search/Tests/SearchKeywordsConditionsTest.php:23: parent::setUp(array('comment', 'search_extra_type')); lib/Drupal/search/Tests/SearchLanguageTest.php:23: parent::setUp(array('language')); lib/Drupal/search/Tests/SearchNodeAccessTest.php:25: parent::setUp(array('node_access_test')); lib/Drupal/search/Tests/SearchPageOverrideTest.php:25: parent::setUp(array('search_extra_type')); lib/Drupal/search/Tests/SearchRankingTest.php:20: parent::setUp(array('statistics', 'comment')); lib/Drupal/search/Tests/SearchTestBase.php:21: parent::setUp($modules);
Code style looks good, and takes care of all instances.
Comments
Comment #1
xjmComment #2
xjmComment #3
xjmComment #4
tim.plunkettCode style looks good, and takes care of all instances.
Comment #5
tim.plunkettComment #6
xjm