See #1711070: Convert tests to use ::$modules property instead of parent::setUp($modules).

CommentFileSizeAuthor
#4 rdf-1711408-4.patch7.31 KBkid_icarus
#4 interdiff.txt4.47 KBkid_icarus
#3 rdf-1711408-3.patch6.8 KBkid_icarus
#1 drupal-1711408-1.patch6.8 KBkid_icarus
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kid_icarus’s picture

kid_icarus CreditAttribution: kid_icarus commented
Assigned: Unassigned » kid_icarus
Status: Active » Needs review
FileSize
drupal-1711408-1.patch6.8 KB
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Status: Needs review » Needs work

See the summary of #1711070: Convert tests to use ::$modules property instead of parent::setUp($modules) for the docblocks that should be added.

kid_icarus’s picture

kid_icarus CreditAttribution: kid_icarus commented
FileSize
rdf-1711408-3.patch6.8 KB

Rerolled to account for 96614a6

kid_icarus’s picture

kid_icarus CreditAttribution: kid_icarus commented
Status: Needs work » Needs review
FileSize
interdiff.txt4.47 KB
rdf-1711408-4.patch7.31 KB

Addresses #2

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs review » Reviewed & tested by the community

Looks good, 8/8 converted.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Reviewed & tested by the community » Closed (duplicate)