See #1711070: Convert tests to use ::$modules property instead of parent::setUp($modules).

CommentFileSizeAuthor
#5 filter-1711346-5.patch2.79 KBkid_icarus
#5 interdiff.txt1.66 KBkid_icarus
#1 drupal-1711346-1.patch2.6 KBkid_icarus
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kid_icarus’s picture

kid_icarus CreditAttribution: kid_icarus commented
Assigned: Unassigned » kid_icarus
Status: Active » Needs review
FileSize
drupal-1711346-1.patch2.6 KB
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs review » Reviewed & tested by the community

More than halfway done I think!

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Status: Reviewed & tested by the community » Needs work

Needs doxygen fix as discussed in IRC. :)

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented

See the summary of #1711070: Convert tests to use ::$modules property instead of parent::setUp($modules) for how the docblock should be added.

kid_icarus’s picture

kid_icarus CreditAttribution: kid_icarus commented
Status: Needs work » Needs review
FileSize
interdiff.txt1.66 KB
filter-1711346-5.patch2.79 KB
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Status: Needs review » Reviewed & tested by the community

Looks good now!

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Reviewed & tested by the community » Closed (duplicate)