It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.
See #1711070: Convert tests to use ::$modules property instead of parent::setUp($modules).
Same weirdness going on here in FieldUiTestBase.php
$modules = func_get_args(); if (isset($modules[0]) && is_array($modules[0])) { $modules = $modules[0]; } parent::setUp($modules);
Thoughts?
Oh that's the same pattern, since setUp would work two ways:
setUp('block', 'node') or setUp(array('block', 'node'))
Can just be removed. Same for the other field issue.
Ok I think I got it. How does this look?
Looks good.
Comments
Comment #1
kid_icarus CreditAttribution: kid_icarus commentedSame weirdness going on here in FieldUiTestBase.php
Thoughts?
Comment #2
tim.plunkettOh that's the same pattern, since setUp would work two ways:
setUp('block', 'node')
or
setUp(array('block', 'node'))
Can just be removed. Same for the other field issue.
Comment #3
xjmComment #4
kid_icarus CreditAttribution: kid_icarus commentedOk I think I got it. How does this look?
Comment #5
tim.plunkettLooks good.
Comment #6
tim.plunkett