Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kid_icarus’s picture

Assigned: Unassigned » kid_icarus
Status: Active » Needs review
FileSize
1.75 KB

Same weirdness going on here in FieldUiTestBase.php

    $modules = func_get_args();
    if (isset($modules[0]) && is_array($modules[0])) {
      $modules = $modules[0];
    }
    parent::setUp($modules);

Thoughts?

tim.plunkett’s picture

Oh that's the same pattern, since setUp would work two ways:

setUp('block', 'node')
or
setUp(array('block', 'node'))

Can just be removed. Same for the other field issue.

xjm’s picture

Status: Needs review » Needs work
kid_icarus’s picture

Status: Needs work » Needs review
FileSize
2.23 KB
3.1 KB

Ok I think I got it. How does this look?

tim.plunkett’s picture

Status: Needs review » Reviewed & tested by the community

Looks good.

tim.plunkett’s picture

Status: Reviewed & tested by the community » Closed (duplicate)