Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kid_icarus’s picture

Assigned: Unassigned » kid_icarus
Status: Active » Needs review
FileSize
964 bytes

Seems simple enough :)

I followed the directions from the meta issue and looked at https://drupal.org/files/drupal-1711434-2.patch

tim.plunkett’s picture

Status: Needs review » Reviewed & tested by the community

Great, thanks.

xjm’s picture

Status: Reviewed & tested by the community » Needs work

Needs doxygen fix as discussed in IRC. :)

xjm’s picture

Status: Needs work » Needs review
FileSize
1.02 KB
1.08 KB

In addition to adding the docblock, I removed the docblock for the setUp() method. (It needed to be changed anyway to remove the mention of enabling modules, and the standards dictate that they have no docblock.)

droplet’s picture

Status: Needs review » Needs work
+++ b/core/modules/dblog/lib/Drupal/dblog/Tests/DBLogTest.phpundefined
@@ -24,12 +32,9 @@ class DBLogTest extends WebTestBase {
+    parent::setUp();
+    // Create users with specific permissions.

can it add a line between doc & code

kid_icarus’s picture

Status: Needs work » Needs review
FileSize
581 bytes
1.08 KB

Sure :)

xjm’s picture

Status: Needs review » Reviewed & tested by the community

Yep, that looks good to me. Thanks @droplet and @kid_icarus!

tim.plunkett’s picture

Status: Reviewed & tested by the community » Closed (duplicate)