The function block_custom_block_get() accepts a bid and not a delta.
The test for if ($delta) { is invalid because strings are valid url arguments.
If a string is passed to block_custom_block_get(), then an SQL error will occur.

This is similar in nature to: #1003788: PostgreSQL: PDOException:Invalid text representation when attempting to load an entity with a string or non-scalar ID.

CommentFileSizeAuthor
#2 drupal-7.x-dev-custom_block_is_bid_not_delta-3.patch556 bytesthekevinday
#1 drupal-7.x-dev-custom_block_is_bid_not_delta-2.patch467 bytesthekevinday
drupal-7.x-dev-custom_block_is_bid_not_delta-1.patch543 bytesthekevinday
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

thekevinday’s picture

thekevinday CreditAttribution: thekevinday commented
FileSize
drupal-7.x-dev-custom_block_is_bid_not_delta-2.patch467 bytes

Try this again.
I left an accidental test conversion (int) that made this patch work when it shouldn't.

thekevinday’s picture

thekevinday CreditAttribution: thekevinday commented
FileSize
drupal-7.x-dev-custom_block_is_bid_not_delta-3.patch556 bytes

Casting one to (float) and rounding the other works better and theres no need for defining a variable $d.

Now, if the bid is not found, it seems a non-array is returned, so also cast the return of block_custom_block_get to an array() to prevent other problems from happening.