Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.In #1270608: File-based configuration API we introduced the new configuration system. This included the settings for block cache. However in #918808: Standardize block cache as a drupal_render() #cache block caching was removed as a feature. This change happened after the initial patches and flew under the radar until now. So what needs to happen is that
- The core/modules/block/config/block.performance.xml file needs to be removed
- The core/modules/block/config directory also needs to go since it will now be empty
Additionally there is a test for block caching in testSystemBlocks() in system.test which should go (or perhaps be rewritten)
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | drupal8.block-cache.6.patch | 3.41 KB | sun |
| #5 | 1591710-5.patch | 1.13 KB | gdd |
| #4 | 1591710-4.patch | 1.02 KB | swentel |
Comments
Comment #1
sunComment #2
gddI was going to set this to block system but there is apparently no block system component which is a little surprising. Also tagging. This would be novice except I suspect getting the patch right to remove the file and directory is probably a bit tricky.
Comment #3
catchWhat's wrong with the block module component (apart from the obvious :P).
Comment #4
swentel CreditAttribution: swentel commentedComment #5
gddThis looks good but it needed a reroll because all the tests moved around. New patch attached.
Comment #6
sunWTF?
Let's delete that entire file.
The entire test case class is poor code that duplicates Block module's actual tests. (which is not to say that the Block tests are any better, but this is definitely dislocated code)
Comment #7
Dries CreditAttribution: Dries commentedCommitted to 8.x. Thanks.