You get warnings like this: file_put_contents(sites/default/files/simpletest/verbose/Drupal\block\Tests\BlockUserAccountSettingsTest-1.html) [function.file-put-contents]: failed to open stream: No such file or directory

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Berdir’s picture

This is a windows issue because on Linux, creating a filename with a \ in it works fine.

The path is generated once in in simpletest_verbose() and once in WebTestBase::verbose().

simpletest_verbose() is only used within WebTestBase. I suggest we merge these two functions and replace \ in $class with _ or something like that.

aspilicious’s picture

Status: Active » Needs review
FileSize
2.01 KB

Working now

aspilicious’s picture

underq’s picture

Work for me !

Berdir’s picture

Status: Needs review » Reviewed & tested by the community

This is the easiest fix for the given bug. Not sure if it makes sense to add a test here, we don't have any test coverage of verbose() yet at all. I'd vote for checking whether we can add test coverage in #1588132: Simpletest verbose output url generation should be centralized..

marcingy’s picture

Priority: Normal » Major

This also works for me bumping to major as it basically prevents tests being run in a meaningful way on windows

sun’s picture

Looks good to me. Would have preferred single quotes (like everywhere else in Drupal), but I won't hold off a commit on that. If you can quickly tweak that and upload a new patch before this gets committed, even better.

aspilicious’s picture

Lets see if this works

Berdir’s picture

Title: Simpletest can't handle namsepaces when creating verbose output. » Simpletest can't handle namespaces when creating verbose output.
catch’s picture

Status: Reviewed & tested by the community » Fixed

Works for me, fine with not adding tests for this and great if we can add them in the other issue.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.