Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
You get warnings like this: file_put_contents(sites/default/files/simpletest/verbose/Drupal\block\Tests\BlockUserAccountSettingsTest-1.html) [function.file-put-contents]: failed to open stream: No such file or directory
Comment | File | Size | Author |
---|---|---|---|
#8 | 1587196-simpletest-verbose-8.patch | 2.01 KB | aspilicious |
#2 | 1587196-simpletest-verbose.patch | 2.01 KB | aspilicious |
Comments
Comment #1
BerdirThis is a windows issue because on Linux, creating a filename with a \ in it works fine.
The path is generated once in in simpletest_verbose() and once in WebTestBase::verbose().
simpletest_verbose() is only used within WebTestBase. I suggest we merge these two functions and replace \ in $class with _ or something like that.
Comment #2
aspilicious CreditAttribution: aspilicious commentedWorking now
Comment #3
aspilicious CreditAttribution: aspilicious commentedFollowup #1588132: Simpletest verbose output url generation should be centralized.
Comment #4
underq CreditAttribution: underq commentedWork for me !
Comment #5
BerdirThis is the easiest fix for the given bug. Not sure if it makes sense to add a test here, we don't have any test coverage of verbose() yet at all. I'd vote for checking whether we can add test coverage in #1588132: Simpletest verbose output url generation should be centralized..
Comment #6
marcingy CreditAttribution: marcingy commentedThis also works for me bumping to major as it basically prevents tests being run in a meaningful way on windows
Comment #7
sunLooks good to me. Would have preferred single quotes (like everywhere else in Drupal), but I won't hold off a commit on that. If you can quickly tweak that and upload a new patch before this gets committed, even better.
Comment #8
aspilicious CreditAttribution: aspilicious commentedLets see if this works
Comment #9
BerdirComment #10
catchWorks for me, fine with not adding tests for this and great if we can add them in the other issue.