Some language negotiation methods don't work when the page-cache (for anonymous visitors) is enabled, but this is never explained in the interface. It took me a while to figure browser detection doesn't work with page-cache, for instance. Yet looking into the source code, I saw this fact was stated explicitly.

CommentFileSizeAuthor
#9 Change_language_negotiation_description-1502816-9.patch2.01 KBjoates
#3 Change_language_negotiation_description-1502816-3.patch1.69 KBjoates
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

YesCT’s picture

YesCT CreditAttribution: YesCT commented
Issue tags: +Novice, +needs initial patch

slightly related: #1833022: Only display interface language detection options to customize more granularity

We might as well start with a small patch to add a helptext note about caching. Maybe include a link to ... a doc page or a readme. The approach might change, but the patch will be a good start for conversation.

joates’s picture

joates CreditAttribution: joates commented
Assigned: Unassigned » joates

i'm working on a patch for this at the Drupal drop-in sprint in London today.

joates’s picture

joates CreditAttribution: joates commented
Status: Active » Needs review
FileSize
Change_language_negotiation_description-1502816-3.patch1.69 KB

uploading patch..

YesCT’s picture

YesCT CreditAttribution: YesCT commented
Issue tags: -needs initial patch

updating tag, since thanks to @joates we have one. :)

YesCT’s picture

YesCT CreditAttribution: YesCT commented
Category: feature » task
Status: Needs review » Reviewed & tested by the community

adding help text more of a task.

the added words make sense and are grammatically correct.

this detection page is a known sore spot, and difficult to understand. but this small patch seems ok on it's own.

YesCT’s picture

YesCT CreditAttribution: YesCT commented
Issue tags: -Novice, -D8MI, -language-base, -negotiation

#3: Change_language_negotiation_description-1502816-3.patch queued for re-testing.

Status: Reviewed & tested by the community » Needs work
Issue tags: +Novice, +D8MI, +language-base, +negotiation

The last submitted patch, Change_language_negotiation_description-1502816-3.patch, failed testing.

YesCT’s picture

YesCT CreditAttribution: YesCT commented
Issue tags: +Needs reroll

adding tag for reroll, tips: http://drupal.org/patch/reroll

joates’s picture

joates CreditAttribution: joates commented
Status: Needs work » Needs review
FileSize
Change_language_negotiation_description-1502816-9.patch2.01 KB

re-rolled..

thx for yr expert guidance Cathy !

YesCT’s picture

YesCT CreditAttribution: YesCT commented
Status: Needs review » Reviewed & tested by the community

with same thought from #5

this detection page is a known sore spot, and difficult to understand. but this small patch seems ok on it's own.
Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks.

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) CreditAttribution: commented
Issue summary: View changes

Updated issue summary.