Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
As listed here: #1423460: [META] List of bugs and typos in Drupal core found by Spleshka
3. In update_fix_d7_install_profile() variable $file is undefined and unnecessary.
Comment | File | Size | Author |
---|---|---|---|
#5 | fix-undefined-variable-1479572-5.patch | 840 bytes | pillarsdotnet |
remove-undefined-variable.patch | 405 bytes | chertzog | |
Comments
Comment #1
chertzogForgot to set to need review.
Comment #2
oriol_e9gGo!
Comment #3
cweagansSo, it would have been really awesome to have some context for this patch. I realize that it was detailed on the other issue, but just looking at this one, there's not really indication that it should actually be committed.
That said, I checked the function and $file isn't actually used anywhere, so this is safe to commit.
Comment #4
webchickThis looks like legit code, but if you follow git blame you see that this was actually added elsewhere. Sorry, I can't remember exactly where.
Committed and pushed to 7.x. Thanks!
Comment #5
pillarsdotnet CreditAttribution: pillarsdotnet commentedReviewing the original issue at #509398: Install profiles should be modules with full access to the Drupal API and all it entails(.install files, dependencies, update_x), I believe that a mistake has been made.
...
...
Patch attached.
Comment #6
droplet CreditAttribution: droplet commented5: fix-undefined-variable-1479572-5.patch queued for re-testing.
Comment #7
YesCT CreditAttribution: YesCT commentedPlease open an separate issue for the follow-up changes in #5.
Might be tricky though, not sure if needs to be done in 8.x.
Leaving it at Needs work until the separate issue is created (or verified it is not needed).