Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
When running aka testing #375397: Make Node module optional
drush site-install --yes
drush pm-disable node comment --yes
drush pm-uninstall comment --yes
the last command fails with
PHP Fatal error: Call to undefined function node_type_get_types() in /Users/clemens/Sites/drupal/d8/www/core/modules/comment/comment.install on line 17
Comment | File | Size | Author |
---|---|---|---|
#3 | comment-1426062-3.patch | 1.31 KB | tim.plunkett |
Comments
Comment #1
naxoc CreditAttribution: naxoc commentedIn
hook_uninstall()
the module cleans up variables like this:A lot of comment modules variables are postfixed with node types, so what do we do? Let node module clean them up? Leave them? Delete based on the first part of the variable name?
Comment #2
naxoc CreditAttribution: naxoc commentedCome to think of it - if the variables are going in CMI-config files at some point, then this issue more or less solves it self.
Comment #3
tim.plunkettHere's a test.
Comment #5
tim.plunkettAs of the latest patch in #731724: Convert comment settings into a field to make them work with CMI and non-node entities, this would be obsolete. Still worth fixing in case that doesn't land.
Comment #6
mtift10 months later this is still a problem and it is still blocked on #731724: Convert comment settings into a field to make them work with CMI and non-node entities
Comment #7
larowlanWould love your help over there (see to-do list in issue summary).
We've been re-rolling it since November.
Comment #8
swentel CreditAttribution: swentel commentedComment is now a field