Part of meta-issue #1310084: [meta] API documentation cleanup sprint

CommentFileSizeAuthor
#5 1367014-d7-toolbar-docs.patch1.89 KBchris.leversuch
#1 1367014-toolbar_module_documentation.patch2.64 KBchris.leversuch
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

chris.leversuch’s picture

chris.leversuch CreditAttribution: chris.leversuch commented
Status: Active » Needs review
FileSize
1367014-toolbar_module_documentation.patch2.64 KB

First attempt.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Reviewed & tested by the community

Nice, small, easy-to-review, and correct patch. Thanks!

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Version: 8.x-dev » 7.x-dev
Assigned: chris.leversuch » Unassigned
Status: Fixed » Patch (to be ported)
Issue tags: +Needs backport to D7
chris.leversuch’s picture

chris.leversuch CreditAttribution: chris.leversuch commented
FileSize
1367014-d7-toolbar-docs.patch1.89 KB

Here's a D7 version. I left out the following changes as I think they're D8 only.

- * Menu callback; toggles the visibility of the toolbar drawer.
+ * Page callback: Toggles the visibility of the toolbar drawer.
+ *
+ * Path: toolbar/toggle
+ *
+ * @see toolbar_menu().

chris.leversuch’s picture

chris.leversuch CreditAttribution: chris.leversuch commented
Status: Patch (to be ported) » Needs review
xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Status: Needs review » Reviewed & tested by the community

Backport looks good.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 7.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.