Labels of the user entities are just not working

It's kind of obvious that you shouldn't change format_username as this would break a lot of things and it doesn't really make sense to have entity_type in a very specific user function.

Let's see whether the tests are running.

+++ b/modules/user/user.testundefined
@@ -2169,3 +2169,45 @@ class UserValidateCurrentPassCustomForm extends DrupalWebTestCase {
+}
\ No newline at end of file

Needs newline

Code looks ok but could you attach a test only file.
Thnx!

EDIT: Ok I missed the TODO in the tests

4 days to next Drupal core point release.

Here is the test patch

And here comes the total patch.

So will this make things show up in the UI that were previously hidden? If so, a screenshot would be much appreciated.

+++ b/modules/user/user.test
@@ -2169,3 +2169,43 @@ class UserValidateCurrentPassCustomForm extends DrupalWebTestCase {
+    $this->anonymous = user_load(0);

Interesting, never seen that. Is there a difference between that and drupal_anonymous_user()?

+++ b/modules/user/user.test
@@ -2169,3 +2169,43 @@ class UserValidateCurrentPassCustomForm extends DrupalWebTestCase {
+    variable_set('anonymous', $name);
+    $this->assertEqual($name, entity_label('user', $this->account), 'The variable anonymous should be used for name of uid 0');

This should be $this->anonymous and not $this->account. That's test fail #1. This shows that the assertion works, which is good. :)

In general, I can't believe we/I missed this in #1096446: entity_label() is not passing along the $entity_type parameter, when looking for label callbacks I only searched for "label" on api.drupal.org, *slapsforehead*...

Interesting, never seen that. Is there a difference between that and drupal_anonymous_user()?

There is a huge difference internally, because user_load does provide a full user object while drupal_anonymous_user has just a small version of it. Let's use drupal_anonymous_user, as this will be probably used on real sites.

About the test failures, *facepalm*. When i made this, the tests runned locally not as well, but i thought that's a problem of my setup.
Okay here is a new one.

Wonder if yoroy's question still stands.

About yoroy's question. Core doesn't use entity_label yet somewhere at all, so nothing changes for the user.

It's basically just an api which could be used on other modules.

Oke, just needs someone to fix the test.

*d8 suffixed patches are ignored by the bot, and this patch has never passed yet, so can't be RTBC.

+++ b/modules/user/user.testundefined
@@ -2169,3 +2169,44 @@ class UserValidateCurrentPassCustomForm extends DrupalWebTestCase {
+    variable_set('anonymous', $name);
+    $this->assert(strpos(entity_label('user', $this->account), $name) !== FALSE, t('The variable anonymous should be used for name of uid 0'));

This is probably an old patch, as checking for the name of the anonymous user but giving the registered account can't work :) Blame me. This was already fixed in #8 but is not part of #13

Here's a new one. I actually edited the patch file, so things might blow up.

I fixed the test and also went back to using assertEqual() directly.

Okay that was the D7 patch, in D8 the argument order is reversed.

This one should work.

+++ b/modules/user/user.module
@@ -192,6 +192,23 @@ function user_uri($user) {
+ * @param $entity
+ *   The entity object.
+ * @param $entity_type
+ *   The entity type.

And that should of course be reversed as well.

+++ b/modules/user/user.test
@@ -2169,3 +2169,44 @@ class UserValidateCurrentPassCustomForm extends DrupalWebTestCase {
+      'description' => 'Tests specific parts of the user entity like the uri callback and the label callback.',

It should be URI callback, right?

+++ b/modules/user/user.test
@@ -2169,3 +2169,44 @@ class UserValidateCurrentPassCustomForm extends DrupalWebTestCase {
+   * Test uri callback.

See above.

+++ b/modules/user/user.test
@@ -2169,3 +2169,44 @@ class UserValidateCurrentPassCustomForm extends DrupalWebTestCase {
+    // @todo: What is the wanted value of the anonymous user uri.

See above.

Oh thanks true.

Okay here is the patch for d8, let's get this ready first before continue to work on the d7 version.

I don't think we need a D7 patch here.
In D7 $entity is passed as first argument so format_username() is fine as 'label callback'.

Ah okay make sense, thanks.

In general the tests should be backported.

With regards to the @todo in the test, user_uri() doesn't care if the user is anonymous or not. Either way it should return a value of 'user/0'.

Let's remove the todo

This looks good but there is a minor whitespace issue:

+ * @param $entity
+ *   The entity object.
+ *
+ * @return
+ *    The name of the user.

Fixed the whitespace myself. I'm marking this RTBC. If there's no objections before Friday I'll commit it then.

RTBC++
Go for it! :)

Looks good.

Thanks, two extras is plenty, so committed and pushed to 8.x.

Discussion here suggests there's no Drupal 7 bug here, but maybe we can backport the tests?

Related: #1227942: Rename format_username() now that it's in user.module

Tests backported and passed locally :D

USER ENTITY CALLBACK TESTS
Tests specific parts of the user entity like the URI callback and the label callback.
7 passes, 0 fails, and 0 exceptions

33: user_entity_tests-1261918-33.patch queued for re-testing.

The patch in #33 only adds tests to modules/user/user.test

Doesn't actually fix the problem.