Currently, we have a bunch of sensible PHP engine default in settings.php. I have almost never changed these on any project, but I'm always wary of dropping them from settings.php because I'm usually sure my php.ini wouldn't provide the same environment on its own. It's silly for Drupal to depend on a magic block of rarely changing PHP function calls in settings.php; we should set these defaults in bootstrap.inc and merely document in settings.php where to look (bootstrap.inc) for other PHP settings users might want to re-override in settings.php over the bootstrap.inc defaults. Making this move will also make it easier for major Drupal version upgrades to change these settings even while carrying forward user settings.php files. Finally, this patch fixes a documentation issue in default.settings.php where we refer to a function that has never existed in Drupal (at least for D5+).
The patch I will be attaching updates bootstrap.inc and default.settings.php accordingly.
Comment | File | Size | Author |
---|---|---|---|
#9 | movephpini.patch | 3.5 KB | David Strauss |
#8 | movephpini.patch | 3.75 KB | David Strauss |
#6 | movephpini.patch | 3.52 KB | David Strauss |
#5 | move-php-ini.diff | 3.52 KB | David Strauss |
#2 | move-php-ini.patch | 3.53 KB | David Strauss |
Comments
Comment #1
Damien Tournoud CreditAttribution: Damien Tournoud commentedThose should definitely go into
drupal_environment_initialize()
. Some of them are already there.I'm going to go ahead and suggest we backport this.
Comment #2
David StraussComment #3
David StraussFix tag reversion.
Comment #4
David StraussI'm testing this out with Damien's suggested move to drupal_environment_initialize().
Comment #5
David StraussNow, with Damien's suggested change (and as a .diff file for the test bot).
Comment #6
David StraussLet's try thing again.
Comment #7
Dave ReidComment #8
David StraussThis moves the ini settings to group them with the others.
Comment #9
David StraussDrop an extraneous whitespace change.
Comment #10
David StraussComment #11
RobLoach#9: movephpini.patch queued for re-testing.
Comment #12.0
(not verified) CreditAttribution: commentedLog message
Comment #21
longwaveThese were moved to container parameters in #2347877: Move DrupalKernel::initializeCookieGlobals() into a SessionConfiguration service