entity_label() is not passing along the $entity_type parameter

Subscribing

Code looks good, haven't tried it out, though.
Elsewhere we use foo($entity_type, $entity) instead of foo($entity, $entity_type). It makes sense to do this here, for backwards compatibility with D7, but since this is marked against 8.x, it does seem a bit weird.

I just looked through all core invocations of hook_entity_info() and found field_test_entity_label_callback. The tests should not pass because of that. I don't really know why that test is in the Field scope not in the Entity scope, but I guess that's not for this issue.

Awesome. This is RTBC.
After committing to D8, http://drupal.org/files/issues/entity_label-1096446-6.D7.patch is RTBC against D7.

Committed to 8.x.

Moving to 7.x for webchick to consider as this is a (small) API change.

Since http://drupal.org/project/title needs this (among probably others in the future), it's not only a "nice-cleanup" kind of thing, but actually quite needed for getting something like Title in D8 core.

Patch is still RTBC.

Suppose D8 should have the same argument order or we stuck with contrib update|upgrade

+++ b/includes/common.incundefined
@@ -7583,7 +7583,7 @@ function entity_label($entity_type, $entity) {
-    $label = $info['label callback']($entity);
+    $label = $info['label callback']($entity, $entity_type);

D7 version is not forware compatible with D8? Any reason has different signatures?

+++ b/includes/common.incundefined
@@ -7584,7 +7584,7 @@ function entity_label($entity_type, $entity) {
-    $label = $info['label callback']($entity);
+    $label = $info['label callback']($entity_type, $entity);

D8 version been commited is different arguments order from D7

Powered by Dreditor.

Removing backport tag now.

I'm confused. Does this need backport to D7 or not? If so, why was the tag removed?

Yes

Oh sorry, I thought the tag was to be used for D8 issues that should be assigned to D7 after commit, that's why I removed it. Yes it should be applied to D7.

Can we get this in, please? The backported patch seems to be RTBC for D7.

I don't see any update documentation added here, is it needed? Adding tag anyway.

Sorry I meant http://drupal.org/update/modules/6/7

There's not a 7/8 page yet (and there is the issue to make API changes node types), but this looks like it could use a mention.

I added a 7.x to 8.x update docs page: http://drupal.org/node/1152742
And added this as the first item.
That would probably need to be updated if the D7 patch got in.

#12: entity_label-1096446-6.patch queued for re-testing.

This seems like it should be pretty harmless. If not, there's always another week or so to test.

Committed to 7.x. Thanks!

Updated the module update documentation: http://drupal.org/node/1152742#label-callback-params