Gzip aggregated CSS and JS

Personally, I think this is critical. Initial page load time is a critical factor for first time visitors. This one almost cuts the initial load time in half. Very significant!

we have outstanding bugs on our gzipped page cache (if first person to view a page has gzip disabled, we still cache that page and send wrong headers). i'd rather see that resolved before we add more gzip.

the implementation here is a bit more interesting since the logic is in .htaccess. is there no performance penalty for this .htaccess check on every request?

also, don't we have to tell the browser that we are sending gzip in the response headers? are we expecting browser to know because filename ends in .gz?

the #description doesn't explain anything about gzip

Subscribing... this should handle CSS and JS files...

With 4 weeks to go, let's see if we can get this in :-)

Owen, did you want to start with a patch based off of your module? If not, I can try and post one in the next few days.

Subscribing.

Since JS aggregation is now in Drupal 6 core as well, I suggest we tackle both CSS and JS aggregation here.

subscribing...

Subscribing.

This had huge potential but unfortunately didn't make it into 6.x. What's holding up the progress on this patch? Is it because of the outstanding bugs on gzipped page cache in core?

Also I agree with Grugnog2 in #5 about the use of .htaccess method, while it is browser compatible, Dries highlighted his desire to make core compatible with lighttpd and other web servers. We should put some consideration for those too if possible.

On my site a typical page is around 100kb in size. About 75kb of that are aggregated js (50kb) and css (25kb) files, which can be compressed down to about 25kb (with stripped comments 17kb).

Even without stripping comments it would cut it in half for first time visitors. And you can get a whole torrent of those from social bookmarking sites. My puny little page gets about 3000 of those occasionally and I'm currently on some cheap shared host. So, it generates about 300mb instead of 150mb. That's a pretty big difference if you ask me.

Since the number of visitors is constantly rising I really would love to see that kind of thing in core ASAP. Otherwise I'll need to switch to some more expensive hosting plan a few months sooner than actually necessary.

subscribing

This topic is pretty hot nowadays, I read two related discussions on contrib modules for 5.x: this one minify the Javascript aggregated file, and this is about "statical" gzipping method. Today I start to use both the approaches combined, and the result is fine. Since aggregation is a core task, I leave this to a small bash script run on cron job. Should JSMin patch to Javascript Aggregator be reused here?

Got tired of waiting and just added it to my installation. Only requires 14 extra lines in .htaccess and 2 in common.inc. These 2 lines need to be added again after updating, but imo it's totally worth the hassle.

The step by step guide is over here:
How to GZip Drupal 6.x's aggregated CSS and JS files

It seems that Zlib support isn't standard for a PHP installation, at least not on non-Windows OSes. Can someone confirm this?

If this is the case, it might stand in the way of adding this.

Surprisingly you're correct. It's silly, but there are indeed a few installations without Zlib support.

If it's implemented as an option, it would be a good idea to guard the setting (defaults to off) with a function_exists('gzencode') condition.

Fortunately the level parameter for gzencode exists since 4.2 and Drupal requires 4.3.5+. So, at least that part won't be an issue.

Well, Drupal 7 requires 5.2+, so that's definitely not an issue. I would think this would need to be implemented like Clean URLs, where the option to enable gzip encoding would be disabled if the function doesn't exist with an explanation of why.

How about a reroll as an option in the Performance settings page?

subscribe.

subscribe

Is there any reason why we're checking function_exists with gzencode? Drupal 7 requires at least PHP 5.2, so wouldn't it be safe to assume it's available?

As for tests, I'd love those to go in with this patch, but won't have the chance to hit it up until next week because I'll be off on vacation. Otherwise, great work! Also, does that clear cache functionality remove the respective .htaccess file?

We do have a UI for core page gzipping - see 'page compression' at admin/settings/performance - and it's a useful thing to have if you're using mod_deflate/mod_gzip etc. We could reword the interface text there and use the same variable for both things though - seems like it'd be the same reason for switching one off as switching off the other.

subscribing

I'm not quite understand, why Drupal don't gziping all other pages, even browser have support for gip (I'm not talking about js and css).
I've tried to found it, but without result. Somebody know some link to the topic?

I think this should be solely be managed through contrib once #352951: Make JS & CSS Preprocessing Pluggable is in.

subscribe

Update: Contributed modules can now do this for 6.x. Once the code freeze is in place (early September), porting these to 7.x shouldn't be that hard.
http://drupal.org/project/javascript_aggregator
http://drupal.org/project/css_gzip

Both modules exclude safari (webkit) so first projects from #30 should be fixed

Safari (webkit) bug https://bugs.webkit.org/show_bug.cgi?id=9521

So there 2 solutions:

1) make filename.css with filename.css.gz.css

2) alternative way is store filename.css (gzipped) and plain filename.nogzip.css

Both work with safari 3 and google chrome

<IfModule mod_rewrite.c>
    RewriteEngine On
# Konqueror and "old" browsers
    RewriteCond %{HTTP:Accept-encoding} !gzip [OR]
    RewriteCond %{HTTP_USER_AGENT} Konqueror
    RewriteRule ^(.*)\.(css|js)$ $1.nogzip.$2 [QSA,L]
</IfModule>			    

<IfModule mod_headers.c>
    Header append Vary User-Agent
# for all  css/js files setup Content-Encoding
    <FilesMatch .*\.(js|css)$>
	Header set Content-Encoding: gzip
	Header set Cache-control: private
    </FilesMatch>
# reset Content-Encoding if not archive
    <FilesMatch .*\.nogzip\.(js|css)$>
	Header unset Content-Encoding
    </FilesMatch>
</IfModule>

Add tag.

#465356: Workaround old safari/webkit bug - CSS Gzip

#290280: Add GZip compression

Been thinking about the safari/webkit bug... because of the rewrite rules, the browser only sees it as *.css where on the file system it is *.css.gz. Changing the extension around would have no effect; in short it's not a bug because the html file doesn't reference *.css.gz it still points to *.css (bug report deals with *.css.gz in the html code). With that in mind this is a fairly straight forward patch for D7, the question is will it be accepted if I write one?

There are 3 functional changes that need to take place
http://api.drupal.org/api/function/drupal_build_css_cache/7 - write *.css.gz files
http://api.drupal.org/api/function/drupal_build_js_cache/7 - write *.js.gz files
http://api.drupal.org/api/function/system_performance_settings/7 - add gzip compression settings

Add this to .htaccess, inside <IfModule mod_rewrite.c> right above # Rewrite URLs of the form 'x' to the form 'index.php?q=x'.

  <FilesMatch "\.(css.gz)$">
    AddEncoding x-gzip .gz
    ForceType text/css
  </FilesMatch>
  RewriteCond %{HTTP:Accept-encoding} gzip
  RewriteCond %{REQUEST_FILENAME}.gz -f
  RewriteRule ^(.*)\.css $1.css.gz [L,QSA]
  
  <FilesMatch "\.(js.gz)$">
    AddEncoding x-gzip .gz
    ForceType text/javascript
  </FilesMatch>
  RewriteCond %{HTTP:Accept-encoding} gzip
  RewriteCond %{REQUEST_FILENAME}.gz -f
  RewriteRule ^(.*)\.js $1.js.gz [L,QSA]

khm.

 AddOutputFilterByType DEFLATE text/css application/x-javascript text/html text/plain text/xml

@chx, that compresses on the fly for every request; slightly slower. Don't forget about level 9; default is 6 if I remember correctly.

AddOutputFilterByType DEFLATE text/css application/x-javascript text/html text/plain text/xml
DeflateCompressionLevel 9

Core caches gzip html, so it's not a way out there request; plus having settings in the UI is a nice usability feature. It's something most people want IMHO. Great point BTW.

#35 doesn't work in IIS.

how does IIS support conditional gzip, so only the clients that support gzip get gzipped content?

@hass IIS rewrite rules are possible different

This is not possible in IIS (for e.g. with Helicon ISAPI_Rewrite, and not at all without payed plugins) and therefore no general solution:

<FilesMatch "\.(css.gz)$">
    AddEncoding x-gzip .gz
    ForceType text/css
</FilesMatch>

@mikeytown2: IIS does not have any GZIP compression feature build in for dynamic files (only for static HTML files). You need to buy extra plugins to archive this - if you think you really need it...

Shrunk gzip .htaccess rules. Escaped all periods . for possible performance increase with pattern matching since . means any character. Anyone wants to test the escaped period hypothesis out?

Option 1

  <FilesMatch "\.gz$">
    AddEncoding x-gzip \.gz
  </FilesMatch>
  #skip gzipped css/js files if browser doesn't accept gzip encoding
  RewriteCond %{HTTP:Accept-encoding} !gzip
  RewriteRule .* - [S=2]
  #CSS
  RewriteCond %{REQUEST_FILENAME}\.gz -s
  RewriteRule (.*)\.css$ $1\.css\.gz [L,QSA,T=text/css]
  #JS
  RewriteCond %{REQUEST_FILENAME}\.gz -s
  RewriteRule (.*)\.js$ $1\.js\.gz [L,QSA,T=text/javascript]

Option 2

  <FilesMatch "\.gz$">
    AddEncoding x-gzip \.gz
  </FilesMatch>
  #CSS
  RewriteCond %{HTTP:Accept-encoding} gzip
  RewriteCond %{REQUEST_FILENAME}\.gz -s
  RewriteRule (.*)\.css$ $1\.css\.gz [L,QSA,T=text/css]
  #JS
  RewriteCond %{HTTP:Accept-encoding} gzip
  RewriteCond %{REQUEST_FILENAME}\.gz -s
  RewriteRule (.*)\.js$ $1\.js\.gz [L,QSA,T=text/javascript]

Option 3 (no escaped periods)

  <FilesMatch "\.gz$">
    AddEncoding x-gzip .gz
  </FilesMatch>
  #skip gzipped css/js files if browser doesn't accept gzip encoding
  RewriteCond %{HTTP:Accept-encoding} !gzip
  RewriteRule .* - [S=2]
  #CSS
  RewriteCond %{REQUEST_FILENAME}.gz -s
  RewriteRule (.*)\.css$ $1.css.gz [L,QSA,T=text/css]
  #JS
  RewriteCond %{REQUEST_FILENAME}.gz -s
  RewriteRule (.*)\.js$ $1.js.gz [L,QSA,T=text/javascript]

Which way would be preferred: 1, 2 or 3?

Gzip setting controlled by page_compression. Trying to make this as simple as possible.

What will happen if the server do not support GZ compression or any of this Apache rewrite rules?

This fails on IIS:

+<FilesMatch "\.js\.gz$">
+  ForceType text/javascript
+</FilesMatch>

But this will work:

+  # Serve gzip compressed js files
+  RewriteCond %{HTTP:Accept-encoding} gzip
+  RewriteCond %{REQUEST_FILENAME}\.gz -s
+  RewriteRule (.*)\.js$ $1\.js\.gz [L,QSA,T=text/javascript]

In such a case the ForceType may not send to the browser, but the compressed file is... I'm not sure if this could cause issues!?

Due to apache weirdness I'm setting the type twice. Once globally in the FilesMatch argument; the other time with T=text/javascript in the RewriteRule. That seems to work 100% of the time on various versions of apache. Does IIS work with T= ?

T=MIME-type should work, see http://www.helicontech.com/isapi_rewrite/doc/RewriteRule.htm

hass, good to hear that works. Here's a slight adjustment to #46, adjusted the regular expression for the rewrite rule so it compares from the start, instead of from the end. Should always work with *.css?5 and things like that. The reason I need both T=MIME-type and the FilesMatch argument is because the newest version of apache doesn't work with T=MIME-type; well you can get it to work if you do some ugly tricks, so FilesMatch is the best way to get around the apache inconsistencies.
http://httpd.apache.org/docs/trunk/mod/mod_rewrite.html#rewriterule

'type|T=MIME-type' (force MIME type)
Force the MIME-type of the target file to be MIME-type. This can be used to set up the content-type based on some conditions. If used in per-directory context, use only - (dash) as the substitution, otherwise the MIME-type set with this flag is lost due to an internal re-processing.

http://httpd.apache.org/docs/2.2/mod/mod_rewrite.html#rewriterule

'type|T=MIME-type' (force MIME type)
Force the MIME-type of the target file to be MIME-type. This can be used to set up the content-type based on some conditions. For example, the following snippet allows .php files to be displayed by mod_php if they are called with the .phps extension:

Another reason why this should be in core
http://code.google.com/speed/articles/gzip.html

Above patch should still be good... re-submitting it.

Suppose bot was broken, so re-test

Works for me. What happens if the user doesn't change .htaccess as this file is usually kept? I understand that nothing will happen for him and he won't see a difference.

Can the new rewrite rules negatively affect performance?

@meba
if the .htaccess file is not changed, then nothing happens; gzipped files do not get served. Performance impact is minimal; I haven't done any benchmarking though; It's hard for me to get access to an idle computer (my benchmarking results would be very unreliable for this small of a change).

Would it be possible to decide whether to serve gzipped file directly in Drupal? We should have accept-encoding header available when printing styles.

I don't understand your question, but here's an answer that hopefully answers what you where trying to say.

The new rules look to see if a css.gz file exists; if it does, that gets sent to the browser. If aggregation is turned off, and you compressed the css files your self, it will serve those as well (css.gz files in themes, ect...). If aggregation is on, printing styles get aggregated; thus they get gzip compressed.

I know how does it work. What I mean is that we already check for gzip encoding capability in bootstrap.inc.

Why don't we just use that information (make return_compressed drupal static?) or simply check again in drupal_get_css and link to gzipped files without a need for additional rewrite rules?

bootstrap.inc:

  $return_compressed = $page_compression && isset($_SERVER['HTTP_ACCEPT_ENCODING']) && strpos($_SERVER['HTTP_ACCEPT_ENCODING'], 'gzip') !== FALSE;

drupal_get_css():

    if ($is_writable && $preprocess_css) {
      // Prefix filename to prevent blocking by firewalls which reject files
      // starting with "ad*".
      $filename = 'css_' . md5(serialize($types) . $query_string) . '.css';
// COULD RETURN GZIPPED FILEPATH IF SUPPORTED?
      $preprocess_file = drupal_build_css_cache($types, $filename);
      $output .= '<link type="text/css" rel="stylesheet" media="' . $media . '" href="' . file_create_url($preprocess_file) . '" />' . "\n";
    }

Your proposal would make the page cache more complicated. it would require 2 different html sets; one with style.css, another with style.css.gz. It would also be incompatible with older webkit browsers (Apple Safari).

@meba anyway we need send specific header for css so this produceв by rewrite rules

Agree with #60, aggregation could be changed but all cached pages,css,js always cleared by system_clear_cache_submit at admin/settings/performance

But UI changes fro different issue

Have one of you verified this in IIS with Helicons ISAPI Rewrite? We are trying to do the same in our non Drupal app and it's not working.

May be related to missing IIS support of:

AddEncoding x-gzip .gz

@hass
Can you send out custom content encoding types in IIS? I don't use IIS so you're sorta on your own.

We tried to do the same in our ColdFusion application on IIS6, but we haven't found a solution yet. I haven't found the time to test the above patch, but I expect after our tests this will result in a broken Drupal site (the gzip'ed CSS/JS files are send to the browser without encoding gzip).

The ISAPI_Rewrite solution from Helicon-Tech do not have the ability to send responds headers. Helicon "Ape" seems to have such a feature, but is only implemented well on IIS7, plus I do not have "Ape". Not sure if there are other ISAPI add-ons for IIS available with such a functionality...

So maybe better to return to different naming css.gz replace with gz.css

How should this help?

I have no env to test rewrite with IIS

This needs to be togglable separate from page compression. People might want to use different methods for compression of page requisites/support files (such as mod_deflate).

UI rework is here #459980: Rework admin/settings/performance

But this issue mostly about css-js compression

@hass
Have you looked at The Microsoft URL Rewrite Module for IIS 7.0

@sun
Good point. I was kind of hoping that #459980: Rework admin/settings/performance would be in by now... anyway here is the patch with more fine-grained control.

here's one that defaults to FALSE just in case that is the desired way to do this.

+++ .htaccess	8 Aug 2009 03:21:52 -0000
@@ -7,6 +7,16 @@
+# Gzip compressed css files are of the type 'text/css'.
...
+# Gzip compressed js files are of the type 'text/javascript'.

"CSS" and "JS" should be written all-upper-case here.

+++ .htaccess	8 Aug 2009 03:21:52 -0000
@@ -89,6 +105,16 @@ DirectoryIndex index.php index.html inde
+  RewriteRule ^(.*)\.css $1\.css\.gz [L,QSA,T=text/css]
...
+  RewriteRule ^(.*)\.js $1\.js\.gz [L,QSA,T=text/javascript]

I see a conversion from .* to .*.gz, but where are those (page) requests handled?

+++ includes/common.inc	8 Aug 2009 03:21:54 -0000
@@ -2627,6 +2627,10 @@ function drupal_build_css_cache($css, $f
+    if (variable_get('css_gzip_compression', TRUE) && function_exists('gzencode') && zlib_get_coding_type() == FALSE) {
@@ -3324,6 +3328,10 @@ function drupal_build_js_cache($files, $
+    if (variable_get('js_gzip_compression', TRUE) && function_exists('gzencode') && zlib_get_coding_type() == FALSE) {

Oh my - with this patch applied, we have this (complex) check at several places throughout core.

At the very least, we want to add a comment what is being checked here and more importantly, why.

Ideally, though, we want to create a helper function that performs those conditions centrally and just returns the result.

+++ modules/system/system.admin.inc	8 Aug 2009 03:21:55 -0000
@@ -1373,6 +1373,13 @@ function system_performance_settings() {
+  $form['bandwidth_optimizations']['css_gzip_compression'] = array(
...
+    '#disabled' => !variable_get('preprocess_css', 0),
@@ -1381,6 +1388,13 @@ function system_performance_settings() {
+  $form['bandwidth_optimizations']['js_gzip_compression'] = array(
...
+    '#disabled' => !variable_get('preprocess_js', 0),

This means I can't enable bandwith optimizations while enabling preprocessing optimizations? That's ugly UX.

23 days to code freeze. Better review yourself.

I've addressed your first 2 concerns.

Ideally, though, we want to create a helper function that performs those conditions centrally and just returns the result.

This could be useful... this is what core does in drupal_page_set_cache()

    if (variable_get('page_compression', TRUE) && function_exists('gzencode')) {
      // We do not store the data in case the zlib mode is deflate. This should
      // be rarely happening.
      if (zlib_get_coding_type() == 'deflate') {
        $cache_page = FALSE;
      }
      elseif (zlib_get_coding_type() == FALSE) {
        $cache->data = gzencode($cache->data, 9, FORCE_GZIP);
      }
      // The remaining case is 'gzip' which means the data is already
      // compressed and nothing left to do but to store it.
    }

Whats your recommendation on this?

This means I can't enable bandwidth optimizations while enabling preprocessing optimizations? That's ugly UX.

How should it be done? Gzip does nothing unless it has aggregated files to play with. Gzip only works if Optimize is enabled, and that is how it's setup.
'#disabled' not '#enabled' ;)

As far as I get it: #disabled _really_ only is when: (function_exists('gzencode') && zlib_get_coding_type() == FALSE) === TRUE

As far as the form is concerned, I'd just go with above condition for #disabled. And let the UX team figure out how to handle dependent configuration settings like this - in a separate issue. (please)

However, I still don't get how *.css.gz or *.js.gz files are handled on the server-side, based on the rewrite rules applied here. Perhaps, I'm just dumb, but it seems like *.css is rewritten to *.css.gz, and Apache will expect those files already exist, while I'm too blind to see a condition that checks whether they really exist?

+++ .htaccess	8 Aug 2009 04:25:43 -0000
@@ -89,6 +105,16 @@ DirectoryIndex index.php index.html inde
+  RewriteCond %{REQUEST_FILENAME}\.gz -s
...
+  RewriteCond %{REQUEST_FILENAME}\.gz -s

Or is it the -s option?

All we could do about those aforementioned compression conditions is to create a new drupal_server_compression_enabled() function. Not sure whether that makes ultimately sense, and most probably, this should be deferred to a separate issue... :-/

Good point with #disabled. That should probably be added to the page_compression checkbox as well.

  $form['page_cache']['page_compression'] = array(
    '#type' => 'radios',
    '#title' => t('Page compression'),
    '#default_value' => variable_get('page_compression', TRUE),
    '#options' => array(t('Disabled'), t('Enabled')),
    '#description' => t("By default, Drupal compresses the pages it caches in order to save bandwidth and improve download times. This option should be disabled when using a webserver that performs compression."),
  );

Apache: It's the -s option. that checks that the file exists and filesize > 0, which all valid gzipped files should be, even if empty.

Also word wrapped the long comment inside the drupal_build_*_cache() functions.

For binary choices I would go for simpler checkbox:

[ ] Enable page compression

#459980: Rework admin/settings/performance went in, so I raised up some issues with it.

Here's the patch again. After encountering a misconfigured server on the boost forum, I did some research and almost no one sends out x-gzip anymore, so i switched it to gzip going against the apache documentation (ie 5.5 sends out gzip, so I think it's stuff like Netscape 3 that uses x-gzip).

Found a use case where having this in core would be nice. #554146: CSS_GZip doesn't work with Pixture and other color-based themes.

re-rolled

aggergated -> aggregated

1. What about renaming variable "css_gzip_compression" to "css_compression" (the same for js).
2. And "Gzip compress JavaScript aggergated files" to "Compress JavaScript aggregated files" (the same for css)?

3. Looks incorrect (see the comment):

+    $form['bandwidth_optimization']['js_gzip_compression'] = array(
+      '#type' => 'checkbox',
+      '#title' => t('Gzip compress JavaScript aggergated files'),
+      '#default_value' => variable_get('css_gzip_compression', FALSE), //// Should be js_gzip_compression

subscribing

+1 for Owen Barton's patch

+1 to #87 - I see no need in setting, only if someone get a trouble with double compression can uncomment line in settings.php

So better to make a line with comment in default.settings.php

If compression issue will be commited #43462: cache_set and cache_get base_url brokenosity
So we can omit this setting at all.

.

tagging (there are many topics about css aggregation)

Here's #36 in patch form for those that need a quick fix for 6/7.

This is not API change, so we can still hope #87 commited

OK, in that case here's a review. +1 from me, this is RTBC except it needs a reroll due to a failed hunk in .htaccess.

I checked the response headers of the aggregated css and js files, and they were gzipped as expected. I also like the way the rewrite is written; it allows non-aggregated files to be compressed manually by creating the .gz file.

From a security perspective, I also verified that the rewriting doesn't allow a access control on private files to be bypassed. (for example, if there was /system/files/super_secret.js.gz, requesting the file without the .gz results in a 404).

The patch also passes the coder tests.

AddEncoding should probably be enclosed in <IfModule mod_mime.c> </IfModule>
http://httpd.apache.org/docs/trunk/mod/mod_mime.html#addencoding

I agree that we have to send proper Vary headers.

+++ .htaccess	9 Apr 2010 19:41:45 -0000
@@ -109,6 +109,34 @@ DirectoryIndex index.php index.html inde
+    # Serve gzip compressed CSS files as 'text/css' (for newer Apache).
...
+    # Serve gzip compressed JS files as 'text/javascript' (for newer Apache).

Will "for newer Apache" hold true in 2 years from now?

+++ includes/common.inc	9 Apr 2010 19:41:45 -0000
@@ -3135,6 +3135,15 @@ function drupal_build_css_cache($css, $f
+    // that rewrite rules are working) and he zlib extension is available then

@@ -4187,6 +4196,15 @@ function drupal_build_js_cache($files, $
+    // that rewrite rules are working) and he zlib extension is available then

*the

114 critical left. Go review some!

@sun
Setting the content type using t=_ was modified to be unusable in apache trunk for some reason http://httpd.apache.org/docs/trunk/rewrite/flags.html#flag_t. The FilesMatch ForceType was pushed into core for apache 2 http://httpd.apache.org/docs/2.0/mod/core.html#forcetype.
Thus since some hosts out there (GoDaddy) still used apache 1.3, in order to make the rules work everywhere I use both settings.

Someone want to post the exact headers we need to send? I'll convert it into apache rules.

Better htaccess rules IMHO

According to http://code.google.com/speed/page-speed/docs/caching.html#LeverageProxyC... It can be Vary or private, so it uses Vary if mod_headers is installed and falls back to the gzipped version being cached for 1 second (not cached in short).

Edit: Looks like A0 is valid, will use that after some feedback.

There's a typo (twice) in the help text:

"and he zlib extension"

A quick benchmark comparison with mod_deflate shows this method to be roughly 3X faster.

On the downside, I couldn't get this patch to actually run (I had to manually create the .gz file).

I got the following notices: (odd though that the test bot didn't report any)

Notice: Undefined variable: data in drupal_pre_render_styles() (line 3121 of /Users/djtack/Sites/7-drupal/drupal/includes/common.inc).
Notice: Undefined variable: uri in drupal_pre_render_styles() (line 3121 of /Users/djtack/Sites/7-drupal/drupal/includes/common.inc).
The specified file temporary://fileO4ppC3 could not be copied, because the destination .gz is invalid. This is often caused by improper use of file_unmanaged_copy() or a missing stream wrapper.
Notice: Undefined variable: data in drupal_pre_render_styles() (line 3121 of /Users/djtack/Sites/7-drupal/drupal/includes/common.inc).
Notice: Undefined variable: uri in drupal_pre_render_styles() (line 3121 of /Users/djtack/Sites/7-drupal/drupal/includes/common.inc).
The specified file temporary://fileLsLaSC could not be copied, because the destination .gz is invalid. This is often caused by improper use of file_unmanaged_copy() or a missing stream wrapper.
Notice: Undefined variable: data in drupal_pre_render_styles() (line 3121 of /Users/djtack/Sites/7-drupal/drupal/includes/common.inc).
Notice: Undefined variable: uri in drupal_pre_render_styles() (line 3121 of /Users/djtack/Sites/7-drupal/drupal/includes/common.inc).
The specified file temporary://filexKeVWw could not be copied, because the destination .gz is invalid. This is often caused by improper use of file_unmanaged_copy() or a missing stream wrapper.

Looks like css processing was completely redone recently.

looks like some white space issues got in recently... anyway moved the logic to the correct location
http://api.drupal.org/api/function/drupal_build_css_cache/7
http://api.drupal.org/api/function/drupal_build_js_cache/7

I have tested this locally and verified that the code works

That's really great, the size is reduced to more than half. Thanks owen for the benchmarks

can we call this RTBC?

Relying on mod_headers does allow one to make the rules a lot simpler. I think this is a good trade off; reason I say trade off is not every server has mod_headers enabled. I know this from my experience from the boost module.

Nice trick with this

RewriteRule \.css\.gz$ - [T=text/css]
RewriteRule \.js\.gz$ - [T=text/javascript]

Have you tested this with apache 1.3x; or at a minimum godaddy shared hosting? Last time I checked they are still using apache 1.3x and godaddy has a huge market share in terms of web hosting.

New rules look good from my point of view.

Patch tested on Ubuntu 8.04, with Apache2.
Didn't have mod headers enabled initially, and it just serves the CSS file normally.

The patch worked fine.
I did encounter one issue, but it isn't a problem with the patch.
I had previously configured Apache to serve js and css compressed using.

#   GZip Js files
AddOutputFilterByType DEFLATE text/css application/x-javascript

After applying the patch, the pages appeared unstyled and js was broken,
as the css and js files had been compressed twice.
Once I worked out what was happening and disabled the rule in the apache conf file, all was good.

Nice usage of the E flag :)Turning off mod_deflate after sending gzipped content is smart. Never would have thought about doing this since the documentation doesn't exactly spell out the no-gzip variable.
Edit: found it http://httpd.apache.org/docs/trunk/env.html#special

Looks good to me

I agree.

+++ includes/common.inc	8 Jul 2010 05:43:46 -0000
@@ -4396,9 +4405,18 @@ function drupal_build_js_cache($files) {
     variable_set('drupal_js_cache_files', $map);

+++ sites/default/default.settings.php	8 Jul 2010 05:43:46 -0000
@@ -371,6 +371,21 @@ ini_set('session.cookie_lifetime', 20000
+# $conf['css_gzip_compression'] = FALSE;
+# $conf['js_gzip_compression'] = FALSE;

Much better variable names than previous patches mistakenly introduced! (we still need to fix those)

Powered by Dreditor.

Subscribing. Would be nice to have in D7!

This looks good to me too. Could use some more eyes.

I'm confused as why:

    # Serve correct content types, and prevent mod_deflate double gzip.
    RewriteRule \.css\.gz$ - [T=text/css,E=no-gzip:1]
    RewriteRule \.js\.gz$ - [T=text/javascript,E=no-gzip:1]

... actually works when:

    RewriteRule ^(.*)\.css $1\.css\.gz [L,QSA]

    RewriteRule ^(.*)\.js $1\.js\.gz [L,QSA]

... are supposed to be the last rewrite rules to be called (L).

But I tested this patch and the behavior is correct. Ready to go in for me.

Am I right in assuming that the earlier rules are targeting already existing files and the following rules after are setting headers for not yet existing files?

Either way, seems like we need better comments in .htaccess then.

+++ .htaccess	22 Sep 2010 16:19:39 -0000
@@ -109,6 +109,32 @@ DirectoryIndex index.php index.html inde
+  <IfModule mod_headers.c>
+    # Rules to correctly serve gzip compressed CSS and JS files.
+    # Requires both mod_rewrite and mod_headers to be enabled.
+    # Serve gzip compressed CSS files if they exist and the client accepts gzip.

Minor: Could we move the first two lines above the IfModule? They seem to be the heading for the entire block.

Powered by Dreditor.

Thanks. Dropping L also makes sense to me.

Just to clarify, any reason why the Multiviews feature cannot work in that case?

#134: drupal-101227-134-css-js-gzip.patch queued for re-testing.

Although badly needed, this is D8 material according to the rules (I had to learn today). It may be backported at a later point in time (though that's unlikely).

Another module I need to port to 7 now. I would really like it if core handled this; this patch is the more efficient and reliable solution.

Umm... patch looks good to me. I can't see why it can't get into 7.x, especially since it will be such an awesome tool for lower-end/shared hosting users.

Patch worked fine for me too.

And i don't see a reason to delay it until 8.x either. Most coredevs approved, the patch even got some polished documentation in the files and the results are outstanding ( at least on my shared host environment ).

+1 for drupal 7.0 beta 1 !

To compliment that, after applying this patch to my drupal 7 test site my co-devs commented in irc about that the site feels faster at the initial load ( and i didn't say a word about that patch! ). So thanks again for all patch suppliers and hope to see it in D7 stable.

OK, committed to CVS HEAD. Thanks.

There are a number of server-side performance issues that this introduced, which didn't get much discussion here, I've opened #1040534: Rewrite rules for gzipped CSS and JavaScript aggregates cause lots of lstats for files that will never exist to work on those.