Problem/Motivation

Warning: Undefined array key "optionset" in drowl_paragraphs_types_preprocess_paragraph__drowl_paragraphs_types__container_slides() (Zeile 252 in modules/contrib/drowl_paragraphs/modules/drowl_paragraphs_types/drowl_paragraphs_types.module).:
at GS

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Anybody created an issue. See original summary.

anybody’s picture

Assigned: anybody » thomas.frobieter
Status: Active » Needs review

@thomas.frobieter: Here's the fix, but I guess this may mean the ['optionset'] variable changed or didn't exist anymore?
So we should check that in detail for a case where we expect it.

Once we're use it still works as expected, this can be merged. The fix is definitely correct, but we should be warned here...

thomas.frobieter’s picture

Yeah, it doesn't work anymore. Sure, unrelated to the fix here, but we need to fix the functionality, even if its only for legacy reasons (see: #3339002: Introduce layout_slideshow layout paragraph type and deprecate old "container_slides" paragraph).

thomas.frobieter’s picture

anybody’s picture

Assigned: anybody » thomas.frobieter
Status: Needs review » Needs work
thomas.frobieter’s picture

I don't have a comment for the fallback reason, not more then I've already wrote. We can remove this with the risk of damaging pages with older versions.

anybody’s picture

Yeah let's just add that "Fallback for older versions:" as comment. So we know we can probably remove it one day and understand what it was for.

thomas.frobieter’s picture

anybody’s picture

@thomas.frobieter perfect, then only the code style fix is left, can be merged afterwards.

thomas.frobieter’s picture

Status: Needs work » Reviewed & tested by the community
thomas.frobieter’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

thomas.frobieter’s picture

Status: Closed (fixed) » Needs work

@anybody got this error again on project DD .. guess we need to fix this in the 8.x-3.x and 8.x-1.x branches too.

  • 52f77737 committed on 8.x-1.x
    Issue #3387952 by Anybody, thomas.frobieter: Warning: Undefined array...

  • e4d8d43a committed on 8.x-3.x
    Issue #3387952 by Anybody, thomas.frobieter: Warning: Undefined array...
thomas.frobieter’s picture

Status: Needs work » Fixed
anybody’s picture

Assigned: thomas.frobieter » Unassigned

Well done, thank you @thomas.frobieter! :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.