Problem/Motivation
Warning: Undefined array key "optionset" in drowl_paragraphs_types_preprocess_paragraph__drowl_paragraphs_types__container_slides() (Zeile 252 in modules/contrib/drowl_paragraphs/modules/drowl_paragraphs_types/drowl_paragraphs_types.module).:
at GS
Steps to reproduce
Proposed resolution
Remaining tasks
User interface changes
API changes
Data model changes
Issue fork drowl_paragraphs-3387952
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
anybody@thomas.frobieter: Here's the fix, but I guess this may mean the
['optionset']variable changed or didn't exist anymore?So we should check that in detail for a case where we expect it.
Once we're use it still works as expected, this can be merged. The fix is definitely correct, but we should be warned here...
Comment #4
thomas.frobieterYeah, it doesn't work anymore. Sure, unrelated to the fix here, but we need to fix the functionality, even if its only for legacy reasons (see: #3339002: Introduce layout_slideshow layout paragraph type and deprecate old "container_slides" paragraph).
Comment #5
thomas.frobieterOkay, this was a easy one, please review: https://git.drupalcode.org/issue/drowl_paragraphs-3387952/-/commit/78f74858e4554b055d0ac67e79c76247a3bd2de7
Comment #6
anybodyComment #7
thomas.frobieterI don't have a comment for the fallback reason, not more then I've already wrote. We can remove this with the risk of damaging pages with older versions.
Comment #8
anybodyYeah let's just add that "Fallback for older versions:" as comment. So we know we can probably remove it one day and understand what it was for.
Comment #9
thomas.frobieterIts already there ;) "Support for older versions of the blazy/slick modules"
Comment #10
anybody@thomas.frobieter perfect, then only the code style fix is left, can be merged afterwards.
Comment #11
thomas.frobieterComment #12
thomas.frobieterComment #14
thomas.frobieter@anybody got this error again on project DD .. guess we need to fix this in the 8.x-3.x and 8.x-1.x branches too.
Comment #17
thomas.frobieterComment #18
anybodyWell done, thank you @thomas.frobieter! :)