Closed (fixed)
Project:
DROWL Paragraphs
Version:
4.x-dev
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Reporter:
Created:
22 Feb 2022 at 13:15 UTC
Updated:
2 Oct 2024 at 13:14 UTC
Jump to comment: Most recent
See #3265673: Nested (Tab & Content) NON-LP paragraphs not saved in 2.x
After lots of debugging I found out that it's not caused by layout_paragraphs:^2 but by the overwrites in paragraph--drowl-paragraphs-types--container-tabs-accordion.html.twig
All other container paragraphs are working fine, but tab containers don't save, with or without children.
See #3265673: Nested (Tab & Content) NON-LP paragraphs not saved in 2.x
Find which in detail causes the problem
Fix it in drowl_paragraphs 4.x
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
anybody@thomas.frobieter I just assigned you for notification, I'll now have a deeper look at the twig file and tell what's causing the problem.
Comment #3
anybodyComment #4
anybody@thomas.frobieter: Found the reason!
It's a missing div... xD
(broken)
vs.
(works!)
Sad story... so tired ... ;)
Comment #5
anybodyComment #6
anybodyOkay, I'd suggest to use
{{ parent() }}instead, like in other paragraphs?We should check all implementations to reduce the risk of this happening again, as Layout Paragraphs 2 seems to be sensitive about the classes on the paragraph container. -.-
Comment #8
anybodyFixed for Tab-Container @thomas.frobieter please check all other overwrites to ensure the wrapper and the attributes assigned by layout_paragraphs 2 are always present.
Afterwards, we should create a new tag release.
Comment #9
anybodyComment #10
anybody@thomas.frobieter until you have the time to check all paragraph types, I'll now already commit MR!15 and create a new stable release with this fix to make it work with layout_paragraphs:^2
Comment #12
anybody@thomas.frobieter could you perhaps ensure this is fixed for all cases so we can close this major issue finally (and be safe)?
Comment #13
anybody@thomas.frobieter ping for final check and confirmation
Comment #14
thomas.frobieterAll other templates in 4.x are fine (also checked drowl_paragraphs_bs templates).