Problem/Motivation

See #3265673: Nested (Tab & Content) NON-LP paragraphs not saved in 2.x

After lots of debugging I found out that it's not caused by layout_paragraphs:^2 but by the overwrites in paragraph--drowl-paragraphs-types--container-tabs-accordion.html.twig

All other container paragraphs are working fine, but tab containers don't save, with or without children.

Steps to reproduce

See #3265673: Nested (Tab & Content) NON-LP paragraphs not saved in 2.x

Proposed resolution

Find which in detail causes the problem
Fix it in drowl_paragraphs 4.x

Remaining tasks

User interface changes

API changes

Data model changes

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Anybody created an issue. See original summary.

anybody’s picture

Assigned: thomas.frobieter » anybody

@thomas.frobieter I just assigned you for notification, I'll now have a deeper look at the twig file and tell what's causing the problem.

anybody’s picture

anybody’s picture

@thomas.frobieter: Found the reason!

It's a missing div... xD

  {{ content }}

(broken)

vs.

<div{{ attributes.addClass(classes) }}>
  {{ content }}
</div>

(works!)

Sad story... so tired ... ;)

anybody’s picture

Assigned: anybody » Unassigned
anybody’s picture

Okay, I'd suggest to use

{{ parent() }} instead, like in other paragraphs?

We should check all implementations to reduce the risk of this happening again, as Layout Paragraphs 2 seems to be sensitive about the classes on the paragraph container. -.-

anybody’s picture

Assigned: Unassigned » thomas.frobieter

Fixed for Tab-Container @thomas.frobieter please check all other overwrites to ensure the wrapper and the attributes assigned by layout_paragraphs 2 are always present.

Afterwards, we should create a new tag release.

anybody’s picture

anybody’s picture

@thomas.frobieter until you have the time to check all paragraph types, I'll now already commit MR!15 and create a new stable release with this fix to make it work with layout_paragraphs:^2

  • Anybody committed b1b298d on 4.x
    Issue #3265862: Tab Container broken with layout_paragraphs:^2
    
anybody’s picture

@thomas.frobieter could you perhaps ensure this is fixed for all cases so we can close this major issue finally (and be safe)?

anybody’s picture

Status: Active » Needs review

@thomas.frobieter ping for final check and confirmation

thomas.frobieter’s picture

Status: Needs review » Fixed

All other templates in 4.x are fine (also checked drowl_paragraphs_bs templates).

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.