Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
i'm not sure if it was intentional but after upgrading draggable views a while back i started seeing ">" symbols on all of the table cells. i took them out and have a diff attached.
Comment | File | Size | Author |
---|---|---|---|
draggableviews-view-draggabletable.tpl_.php_.diff | 1.38 KB | jjkiesch | |
Comments
Comment #1
sevi CreditAttribution: sevi commentedHm, strange.
But the problem must be somewhere else because the tags would not be closed without the ">".
Comment #2
dalejung CreditAttribution: dalejung commentedSevi,
The issue is that the tpl has <? and not <?php
Just replace those and it'll be fine. Might be why you might not see them.
Comment #3
dalejung CreditAttribution: dalejung commentedSevi, do you need me to post a patch or did my one liner make sense?
Comment #4
jjkiesch CreditAttribution: jjkiesch commentedoops, i didn't see that it was the > for the closing html tag. i can confirm that adding the php fixes the issue
Comment #5
sevi CreditAttribution: sevi commentedNormally your one liner would be enough. But I still don't understand what's going on here O_o. I've never heard before that there's a difference between <? and <?php. The templates of views module use <?php too.
Yes, please write a patch for me :)
And could you please explain it to me?
Greetings,
sevi
Comment #6
dalejung CreditAttribution: dalejung commentedI will make a patch later. The issue was that the tpl was using <? and NOT <?php. Not all webservers are configured to trigger php processing from <? ?> tags. Actually, most servers I've been on only recognize <?php ?> as php.
You will notice that after the print $zebra you're using a <?.
Comment #7
sevi CreditAttribution: sevi commentedOh, ok. I thought you want me to use <? instead of <?php. You're right. I haven't noticed that I use <? in my template.
I don't need you to write a patch for me :)
I'll commit this immediately.
Greetings,
sevi
Comment #8
sevi CreditAttribution: sevi commentedComment #10
dboulet CreditAttribution: dboulet commentedMarked #474762: Remove use of PHP short tag in theme and #476936: Template file has short PHP tags as duplicates.