i'm not sure if it was intentional but after upgrading draggable views a while back i started seeing ">" symbols on all of the table cells. i took them out and have a diff attached.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sevi’s picture

Hm, strange.
But the problem must be somewhere else because the tags would not be closed without the ">".

dalejung’s picture

Sevi,

The issue is that the tpl has <? and not <?php

Just replace those and it'll be fine. Might be why you might not see them.

dalejung’s picture

Sevi, do you need me to post a patch or did my one liner make sense?

jjkiesch’s picture

oops, i didn't see that it was the > for the closing html tag. i can confirm that adding the php fixes the issue

sevi’s picture

Normally your one liner would be enough. But I still don't understand what's going on here O_o. I've never heard before that there's a difference between <? and <?php. The templates of views module use <?php too.

Yes, please write a patch for me :)
And could you please explain it to me?

Greetings,
sevi

dalejung’s picture

I will make a patch later. The issue was that the tpl was using <? and NOT <?php. Not all webservers are configured to trigger php processing from <? ?> tags. Actually, most servers I've been on only recognize <?php ?> as php.

-      <tr class="draggable <?php print $zebra; ?><? if ($draggableviews_extended[$count]) print ' '. 'draggableviews-extended'; ?><? if ($tabledrag_type[$count]) print ' '. $tabledrag_type[$count]; ?>">

You will notice that after the print $zebra you're using a <?.

sevi’s picture

Oh, ok. I thought you want me to use <? instead of <?php. You're right. I haven't noticed that I use <? in my template.
I don't need you to write a patch for me :)

I'll commit this immediately.

Greetings,
sevi

sevi’s picture

Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

dboulet’s picture