Drupal 8.6 error

I confirm that the patch #2 works for me, thanks Pasqualle

Patch applies cleanly and works nicely.
Code checks out.
RTBC

Changing this to critical because it causes WSOD on updating core to 8.6 which is now a full release.

Oh... but this change isn't going to be backwards-compatible. Might require a new branch?

#2 works, thanks Pasqualle.
Please commit, this is a major problem.

#2 patch resolved my issue as well. Thanks

site is completely inaccesssable without patch in 2

Is this project still alive?
This is a critical bug.

Thank you @
Comment #2Pasqualle

- for the patch in comment 2. I found this to fix this issue.

RTBC. Works fine; without it my site is unusable on D8.6.

#2 patch fixes the issue for me. Thanks!

This module is unusable without this patch. Thanks @Pasqualle.

Is this backward compatible with older versions of drupal 8.x? just something to think about

@hanoii probably not :/
Since the constructur / dependency injection thing of BulkForm changed.

One could not overwrite the constructors / do the dependency injection thing and calling the services as they are needed inside the methods, might make it compatible with older drupal versions, but is bad practice as far as i know..

I recently got co-maintainer access and will soon commit a patch/fix for this. I went with a different approach, appreciate more testings.

This will work with 8.5 as well as being more future proof.

I am using this pattern used by search api: https://www.previousnext.com.au/blog/safely-extending-drupal-8-plugin-cl....

I will commit it soon, but if somebody can test it, the better!

That looks like it will work. One thing I would do is put in a comment regarding the non-standard use of the container and why it is necessary for a few reasons:

1. It will help us remember why it is like that in future years
2. It will help avoid confusion for any newer developers
3. Relatedly, it should help avoid this non-standard usage proliferating in unnecessary places

I wouldn't call it non-standard: https://symfony.com/doc/current/service_container/injection_types.html#s..., but feel free to submit a patch with the suggested documentation.

Was anybody able to test the patch?

Woa thanks @hanoii for the pattern links!! I like this stuff.

Havent got a chance to test it on a lower version than 8.5 since we already updated every page to 8.6

The injection as a setter is fine, but there isn't a single example in core of create() being extended with regards to container injection. However, I take your point, having now read your linked article properly I concede that it doesn't really require a warning.

I've tested on 8.6 in our complicated build with no issues, don't have anywhere to test 8.5 at the moment, sorry. I spun up a test site with a standard install and turned on the demo from the module, but that didn't work in 8.5 or 8.6, with or without the patch, and I don't have the time to troubleshoot it.

#16 patch fixes the issue for me.

Thanks!

This has been committed, I will soon release a new version seeing if it's safe to do so and then might try to wrap up other issues.