I'm using Domain Path and Display Suite's view mode switcher together on a node form. When I switch the node's view mode, there's an in-page AJAX request that updates part of the form, and domain_path_node_validate() is called as part of the AJAX form processing.

At that point in the processing, there's no value for $form_state['values']['op'], which domain_path_node_validate() tests to see if the node is being deleted. This results in a PHP notice.

An isset() check should be all that's needed here.

CommentFileSizeAuthor
#1 domain_path-2155507-1.patch719 bytesLes Lim
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Les Lim’s picture

Les Lim
he/they
Primary language English
CreditAttribution: Les Lim commented
Status: Active » Needs review
FileSize
domain_path-2155507-1.patch719 bytes

Patch attached.

Stefan Looij’s picture

Stefan Looij CreditAttribution: Stefan Looij commented

Just letting you know this small fix did remove the PHP notice for me.

bnadem’s picture

bnadem CreditAttribution: bnadem commented

I confirm that this patch removed the PHP Notice for me too.
Thanks for sharing this ;)

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
CreditAttribution: agentrickard at Palantir.net for Somos Educação commented
Status: Needs review » Reviewed & tested by the community

Two reviews means you can mark it RTBC.

i-trokhanenko’s picture

i-trokhanenko
Location Lutsk 🇺🇦
CreditAttribution: i-trokhanenko at Cyber-Duck commented

Committed patch #1

i-trokhanenko’s picture

i-trokhanenko
Location Lutsk 🇺🇦
CreditAttribution: i-trokhanenko at Cyber-Duck commented
Status: Reviewed & tested by the community » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.