Needs review
Project:
Domain Login Restrict
Version:
8.x-1.2
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
24 Jan 2023 at 15:32 UTC
Updated:
23 Feb 2026 at 17:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
sunilpawar commentedWe are storing the additional setting for the domain in a state like this.
Comment #3
sunilpawar commented@petr-illek
Do you have PATCH for it ?
Comment #4
thejimbirch commentedI ran into this today. The configuration for the two settings is not exported.
Will try to find some tie to investigate.
Comment #5
earthday47Comment #7
earthday47I'm happy to help and supply a patch! I added MR 6 which converts State into configuration. I've also attached a patchfile to this comment.
Note that in this patch I've saved all the domain-specific configuration into the same domain_login_restrict.settings configuration object. Ideally, these config would be saved as 3rd party settings on the domain entities, but that's something that could be tackled in a future update.
Comment #8
thejimbirch commentedThanks for the patch Wes, and the knowledge that states are only saved in the database, not in config!
I will test this on my project next week!
Comment #10
t_d_d commentedAdded removal of state after config is created. New patch attached.
Note that when domain was previously created, had configuration saved in state and then was removed, its configuration is still saved in state and will remain there as there is no longer domain by which we can find that stale state now. Not sure how to solve this.
I guess it is the same for new config approach. It will too get stale when domain is removed later, but we can resolve that one in future when moving configuration to domain.
Comment #11
alexandre.todorov commentedHello,
For those who want to apply this patch on the D11 compatibility commit, here is the rerolled patch on that commit 8bbdc8ffb
Comment #12
alexandre.todorov commentedAnd here is the rerolled version on the latest 8.x-1.x : e71777134
Comment #13
sunilpawar commentedCan you update MR : https://git.drupalcode.org/project/domain_login_restrict/-/merge_requests/6 so i can merge it.