Support from Acquia helps fund testing for Drupal Acquia logo

Comments

naveenvalecha created an issue. See original summary.

naveenvalecha’s picture

FileSize
2.14 KB

naveenvalecha’s picture

Issue summary: View changes

@Rohit joshi
Could you post the improved patch here so that it would be easier to commit.

pratik.mehta19’s picture

Hi naveenvalecha.

are you working on this or else we can take up.

naveenvalecha’s picture

No, I'm not working on it. Feel free to pick it up

//Naveen

shylajaphp’s picture

Assigned: Unassigned » shylajaphp

I am working on it.

shylajaphp’s picture

Hi,
I have added the changes from "https://github.com/neetumorwani/domain_301_redirect/". Please review it.

shylajaphp’s picture

FileSize
35.74 KB
shylajaphp’s picture

FileSize
39.09 KB
9 KB

Hi,
I have added patch9 and interdiff of patch8 and patch9. Please review it.

shylajaphp’s picture

Assigned: shylajaphp » Unassigned
Status: Needs work » Needs review
shylajaphp’s picture

Hi,

Pphpcs Formatting done in domain_301_redirect\EventSubscriber\DomainRedirectEventSubscriber.php;

shylajaphp’s picture

Hi naveenvalecha,
Please review the patch attached.

naveenvalecha’s picture

This needs reroll

badjava’s picture

Status: Needs review » Closed (duplicate)

I am closing this issue as duplicate as the event subscriber was completed as part of #2775825: Drupal 8 port.