Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Follow-up to #2775825: Drupal 8 port
Port domain_301_redirect_init to drupal 8
Looks at the code at this PR https://github.com/neetumorwani/domain_301_redirect/pull/5 this does not looks nice and it needs work. So posting the patch from there
https://patch-diff.githubusercontent.com/raw/neetumorwani/domain_301_red...
Here's another followup PR found https://github.com/neetumorwani/domain_301_redirect/pull/13
Comment | File | Size | Author |
---|---|---|---|
#12 | formating_done-2805871-12.patch | 38.49 KB | shylajaphp |
#10 | 2805871-8-9.txt | 9 KB | shylajaphp |
#10 | 2805871-9.patch | 39.09 KB | shylajaphp |
#9 | 2805871-8.patch | 35.74 KB | shylajaphp |
#2 | 2805871-2.patch | 2.14 KB | naveenvalecha |
Comments
Comment #2
naveenvalechaComment #4
naveenvalecha@Rohit joshi
Could you post the improved patch here so that it would be easier to commit.
Comment #5
pratik.mehta19 CreditAttribution: pratik.mehta19 commentedHi naveenvalecha.
are you working on this or else we can take up.
Comment #6
naveenvalechaNo, I'm not working on it. Feel free to pick it up
//Naveen
Comment #7
shylajaphp CreditAttribution: shylajaphp at Iksula commentedI am working on it.
Comment #8
shylajaphp CreditAttribution: shylajaphp at Iksula commentedHi,
I have added the changes from "https://github.com/neetumorwani/domain_301_redirect/". Please review it.
Comment #9
shylajaphp CreditAttribution: shylajaphp at Iksula commentedComment #10
shylajaphp CreditAttribution: shylajaphp at Iksula commentedHi,
I have added patch9 and interdiff of patch8 and patch9. Please review it.
Comment #11
shylajaphp CreditAttribution: shylajaphp at Iksula commentedComment #12
shylajaphp CreditAttribution: shylajaphp at Iksula commentedHi,
Pphpcs Formatting done in domain_301_redirect\EventSubscriber\DomainRedirectEventSubscriber.php;
Comment #13
shylajaphp CreditAttribution: shylajaphp at Iksula commentedHi naveenvalecha,
Please review the patch attached.
Comment #14
naveenvalechaThis needs reroll
Comment #15
badjava CreditAttribution: badjava at Metasun for Pfizer, Inc. commentedI am closing this issue as duplicate as the event subscriber was completed as part of #2775825: Drupal 8 port.