Please create a new release tag for 8.x [#2925726]

The current release `8.x-1.0-alpha9 released 23 April 2017` doesn't pass setup phase on Drupal core 8.4.x
with error:

Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for field.field.user.user.field_domain_admin with the following errors: field.field.user.user.field_domain_admin:settings.handler_settings.target_bundles missing schema, field.field.user.user.field_domain_admin:settings.handler_settings.sort missing schema

/var/www/html/core/lib/Drupal/Core/Config/Development/ConfigSchemaChecker.php:95
/var/www/html/core/lib/Drupal/Component/EventDispatcher/ContainerAwareEventDispatcher.php:108
/var/www/html/core/lib/Drupal/Core/Config/Config.php:227
/var/www/html/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:280
/var/www/html/core/lib/Drupal/Core/Entity/EntityStorageBase.php:392
/var/www/html/core/lib/Drupal/Core/Config/Entity/ConfigEntityStorage.php:259
/var/www/html/core/lib/Drupal/Core/Entity/Entity.php:377
/var/www/html/core/lib/Drupal/Core/Config/Entity/ConfigEntityBase.php:637
/var/www/html/core/lib/Drupal/Core/Config/ConfigInstaller.php:330
/var/www/html/core/lib/Drupal/Core/Config/ConfigInstaller.php:134
/var/www/html/core/lib/Drupal/Core/ProxyClass/Config/ConfigInstaller.php:75
/var/www/html/core/lib/Drupal/Core/Extension/ModuleInstaller.php:252
/var/www/html/core/lib/Drupal/Core/ProxyClass/Extension/ModuleInstaller.php:83
/var/www/html/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:421
/var/www/html/core/tests/Drupal/Tests/BrowserTestBase.php:980
/var/www/html/core/tests/Drupal/Tests/BrowserTestBase.php:455

Details https://www.drupal.org/pift-ci-job/794887

This breaks automated tests for Modules dependable on "domain".

Please create a new release tag for 8.x from the latest 8.x-dev to resolve the issue.
Thank you in advance.

Comments

Comment #1

23 November 2017 at 05:08

itsekhmistro created an issue. See original summary.

Comment #2

agentrickard

he/him

English

Georgia (US)

CreditAttribution: agentrickard at Palantir.net commented 27 November 2017 at 15:44

I don't understand. What does this error have to do with release tags?

I was hoping to get #2923659: Views support for domain source in before rolling a release.

Comment #3

agentrickard

he/him

English

Georgia (US)

CreditAttribution: agentrickard at Palantir.net commented 27 November 2017 at 15:46

Side note: How are you testing Country Path on d.o.? Do you not use multiple domain requests?

Comment #4

agentrickard

he/him

English

Georgia (US)

CreditAttribution: agentrickard at Palantir.net commented 27 November 2017 at 15:47

These two bugs also need to be fixed for a new tag:

#2925629: Saving after sort order change overwrites hostname with alias
#2925798: Saving domain on edit page may result in undesired domain sort order change

Comment #5

itsekhmistro CreditAttribution: itsekhmistro at Adyax commented 27 November 2017 at 21:01

Hi,

>Side note: How are you testing Country Path on d.o.? Do you not use multiple domain requests?

You can configure Auto-tests for the Domain module here https://www.drupal.org/node/99990/qa

Comment #6

agentrickard

he/him

English

Georgia (US)

CreditAttribution: agentrickard at Palantir.net commented 27 November 2017 at 21:30

I know about auto tests, but how do you run browser tests that require multiple subdomains. Does the d.o. infrastructure support that?

In our Travis setup, we do this:

addons:
  hosts:
    - example.com
    - one.example.com
    - two.example.com
    - three.example.com
    - four.example.com
    - five.example.com

Without those, none of the tests have any value.

Comment #7

agentrickard

he/him

English

Georgia (US)

CreditAttribution: agentrickard at Palantir.net commented 27 November 2017 at 21:34

Another side-note: when the new release is tagged, this is going to land -- https://github.com/agentrickard/domain/pull/377 -- DomainLoader will still work, but will be removed before final release, likely in beta2.

Comment #8

agentrickard

he/him

English

Georgia (US)

CreditAttribution: agentrickard at Palantir.net commented 30 November 2017 at 22:09

The big blockers and a bug fix just went in. There are two very minor bugfixes I'd like to tackle. Then I can tag a release. Perhaps in the morning (US time) of DEC-1.