Add a basic test to see if config schema is valid. This is to make sure the patch in #3077525: Add schema for settings works as expected. I'm going to attempt if the approach at #2886266: Test that config passes schema inspection works.

CommentFileSizeAuthor
#16 3143632-16.patch1.65 KBhussainweb
#15 3143632-15.patch2.75 KBhussainweb
#13 3143632-13.patch1.76 KBhussainweb
#10 3143632-10.patch1.73 KBhussainweb
#8 3143632-8.patch675 byteshussainweb
#6 3143632-6.patch626 byteshussainweb
#4 3143632-4.patch617 byteshussainweb
#2 3143632-2.patch584 byteshussainweb

Comments

hussainweb created an issue. See original summary.

hussainweb’s picture

hussainweb
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new 3143632-2.patch584 bytes

Let's try

hussainweb’s picture

hussainweb
Primary language English
commented

I found another issue which hinted that this is the right approach to test schema. In #3085225: Enable strict config schema checking in \Drupal\Tests\field_group\Functional\ManageDisplayTest, the strict config schema tests are re-enabled (which means it is enabled by default).

hussainweb’s picture

hussainweb
Primary language English
commented
StatusFileSize
new 3143632-4.patch617 bytes

Trying again

Status: Needs review » Needs work

The last submitted patch, 4: 3143632-4.patch, failed testing. View results

hussainweb’s picture

hussainweb
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new 3143632-6.patch626 bytes

The schema is already present in the field module, so maybe this would work?

Status: Needs review » Needs work

The last submitted patch, 6: 3143632-6.patch, failed testing. View results

hussainweb’s picture

hussainweb
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new 3143632-8.patch675 bytes

Progress. Let's try installing user explicitly.

Status: Needs review » Needs work

The last submitted patch, 8: 3143632-8.patch, failed testing. View results

hussainweb’s picture

hussainweb
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new 3143632-10.patch1.73 KB

We're getting more specific now. Combining it with the patch in #3077525-4: Add schema for settings.

Status: Needs review » Needs work

The last submitted patch, 10: 3143632-10.patch, failed testing. View results

hussainweb’s picture

hussainweb
Primary language English
commented

Retesting after committing #3143656: Remove unnecessary field storage settings

hussainweb’s picture

hussainweb
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new 3143632-13.patch1.76 KB

Testing with the latest patch from #3077525-5: Add schema for settings.

Status: Needs review » Needs work

The last submitted patch, 13: 3143632-13.patch, failed testing. View results

hussainweb’s picture

hussainweb
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new 3143632-15.patch2.75 KB

We're getting better errors now. Fixing the schema.

hussainweb’s picture

hussainweb
Primary language English
commented
StatusFileSize
new 3143632-16.patch1.65 KB

Yay. The schema is now committed in #3077525: Add schema for settings. Let's commit the proper patch here.

  • hussainweb committed db11606 on 8.x-1.x 
    Issue #3143632 by hussainweb: Add a config schema test
hussainweb’s picture

hussainweb
Primary language English
commented
Status: Needs review » Fixed
hussainweb’s picture

hussainweb
Primary language English
commented
Parent issue: » #3078585: Writing tests

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.