In Disqus module there is a hook_node_load being used. In this hook node load there is a url being created. But the url triggers another hook. Hook outbound alter.

We have some custom code which uses hook outbound alter which uses node_access which in turn triggers an infinite loop.

My patch builds the url differently.

What is the proper way of using the outbound alter. If you cant use node_load or node_access?

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ruudvanoijen created an issue. See original summary.

ruudvanoijen’s picture

Status: Active » Needs review
FileSize
1010 bytes

the patch

ruudvanoijen’s picture

askibinski’s picture

Issue summary: View changes
askibinski’s picture

Assigned: ruudvanoijen » Unassigned
paulvandenburg’s picture

Status: Needs review » Reviewed & tested by the community

Reviewed, has been running in production for over a year.

JoshaHubbers’s picture

FileSize
908 bytes

This patch is only for the 1.12 version of this module, and purely intended for use in make files. So please ignore this patch...

DamienMcKenna’s picture

DamienMcKenna’s picture

Title: Infinite loop hook_node_load » Infinite loop in hook_node_load()
Status: Reviewed & tested by the community » Fixed

Committed. Thank you.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.