CommentFileSizeAuthor
#7 disqus-n2823685-7.patch36.24 KBDamienMcKenna
#7 disqus-n2823685-7.interdiff.txt32.66 KBDamienMcKenna
#2 fix_coding_standard_2823685-1.patch6.75 KBprince_kr
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

prince_zyxware created an issue. See original summary.

prince_kr’s picture

prince_kr CreditAttribution: prince_kr at Zyxware Technologies commented
FileSize
fix_coding_standard_2823685-1.patch6.75 KB

Updated the patch fixing the coding standard issues with the module.

prince_kr’s picture

prince_kr CreditAttribution: prince_kr at Zyxware Technologies commented
Status: Active » Needs review
cindytwilliams’s picture

cindytwilliams CreditAttribution: cindytwilliams at Kanopi Studios commented
Status: Needs review » Reviewed & tested by the community

Patch applied cleanly and fixes coding standard issues (missing spaces). Module works as expected. Marking RTBC.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Parent issue: » #3240476: Plan for Disqus 7.x-1.13-beta1
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Title: Fix Drupal coding standard - spacing issues » Fix Drupal coding standards
Assigned: Unassigned » DamienMcKenna
Category: Support request » Task
Status: Reviewed & tested by the community » Needs work

This needs some updating, there are more issues to work through than what the patch covers.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Assigned: DamienMcKenna » Unassigned
Status: Needs work » Needs review
FileSize
disqus-n2823685-7.interdiff.txt32.66 KB
disqus-n2823685-7.patch36.24 KB

Lots of minor changes.

Status: Needs review » Needs work

The last submitted patch, 7: disqus-n2823685-7.patch, failed testing. View results

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Related issues: +#3243325: Add test coverage for the 7.x-1.x branch

I'm going to add test coverage before committing this.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs work » Fixed

On second thoughts, I'll commit this then do the tests.

  • DamienMcKenna committed f2c73d1 on 7.x-1.x 
    Issue #2823685 by DamienMcKenna, prince_kr, cindytwilliams: Fix Drupal...