Problem/Motivation

Seems like in the re-write for D8, we didn't copy in the logic for #969202: Respect protocol of the page request.

Proposed resolution

Let's make that js script protocol-less.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 disqus-respect_protocol_of_the-2809615-2.patch645 bytesheddn
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

heddn created an issue. See original summary.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented
FileSize
disqus-respect_protocol_of_the-2809615-2.patch645 bytes
heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented
Status: Active » Needs review
casismary’s picture

casismary CreditAttribution: casismary at Webizat commented
Status: Needs review » Reviewed & tested by the community

Hi @heddn,

I was having an issue on a site using https with disqus. I tested patch #2 and it worked as designed.
After using the patch, the scripts were now loading the https and error messages on my console dissappeared.

Thanks,

Mary

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented

Closing #2856592: Block incorrectly uses http: protocol to load JS as duplicate. Any chance of a merge here? This has been RTBCed for 6 months.

Anybody’s picture

Anybody
Primary language German
Location Porta Westfalica
CreditAttribution: Anybody commented

Confirming RTBC and importance of this issue!

Please commit this patch.

Anybody’s picture

Anybody
Primary language German
Location Porta Westfalica
CreditAttribution: Anybody commented

Still nothing new here? No active maintainer?
This is RTBC!

DarkteK’s picture

DarkteK CreditAttribution: DarkteK commented

Comment #1 worked great

Anybody’s picture

Anybody
Primary language German
Location Porta Westfalica
CreditAttribution: Anybody commented

Any active maintainers? This is RTBC since months...

Anybody’s picture

Anybody
Primary language German
Location Porta Westfalica
CreditAttribution: Anybody commented

Any news on this @maintainer?

  • RobLoach committed 4317c37 on 8.x-1.x authored by heddn 
    Issue #2809615 by heddn: Respect protocol of the page request
RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach at Kalamuna commented
Status: Reviewed & tested by the community » Fixed

Merged! Thanks a lot.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.