Closed (fixed)
Project:
Disqus
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
13 Jun 2015 at 20:38 UTC
Updated:
14 May 2016 at 11:03 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
slashrsm commentedWe fixed very similar thing in #2501743: Default Disqus status is always TRUE., which was already committed. Can you test 7.x-1.x-dev and report back?
Comment #2
yeaha commentededit: no problems anymore with -dev version
Comment #3
stellarvisions commenteddev did not fix for us -- http://stellarvisions.com
drupal 7.38
Comment #4
isherwood commentedSame problem at http://blog.atomiclearning.com/highed with both stable and dev releases. The problem is intermittent, showing up maybe 25% of the time.
Comment #5
slashrsm commentedPlease test (not in production!!) https://www.drupal.org/node/2508561#comment-10039259. Note that patch might need an update hook that is not there yet.
Comment #6
slashrsm commentedIt would be great if you could report more details about your sites (how many nodes, how many of those had Disqus enable before upgrading to 7.x-1.11, ...).
Comment #7
hunterking commentedNeither the dev version nor the patch worked for me. Had Disqus working for probably 9 months or so, set to show on every new blog post. While the actual comment form doesn't load, the comments block (recent comments etc) does.
I'm disabling it for now but my site is www.stormsurgeofreverb.com
Comment #8
slashrsm commentedPlease test if this patch fixes this problem.
Comment #9
warrenreario commentedSame errors with the 7.x-1.12 version
Comment #10
teek commentedI too have this problem, see here: https://myrpi.nl/node?page=1
There are no errors in the pages where Disqus is supposed to load it seems (in the blog posts/tutorials)
I'm using 7.x-1.12 and the most recent drupal 7.
Comment #11
slashrsm commentedPlease test patch in #8 and report back if it fixes the issue or not.
Comment #12
vincer commentedPatch #8 cleaned the noscript and post_render issues.
But then I got:
Comment #13
slashrsm commented@vincer: Can you test #2508561: Default value handling is broken (Impossible to enable commenting)?
Comment #14
Media Crumb commentedDev worked fine for me
Comment #15
slashrsm commentedWe still have an uncommitted patch in this issue.
Comment #16
teek commentedI have the same issue, even with dev (drupal 7.38), see example: https://myrpi.nl/node?page=1
Is happens only on page 1, not on the first nor on the last page.
(Edit: this was supposed to be a reply to vincer)
Comment #17
teek commentedI've moved back to disqus-7.x-1.10 which removes the issue for me, the issue is present in disqus-7.x-1.11, disqus-7.x-1.12 and disqus-7.x-1.x-dev.
Comment #18
slashrsm commentedCan you please test patch in #8? That patch hasn't been committed yet.
Comment #19
vincer commentedI retested with a fresh 7.x-1.x-dev and patch node/2508561 #10.
It seems to be fine now. :)
I haven't added this patch, from this report.
Comment #20
teek commented@slashrsm Sorry, I have no idea how to patch. Perhaps later in time I can be of more assistance.
Comment #21
CriticalBlast commentedSame here -- I'm not a patcher. Just waiting for the next (fixed) version of this to show up in my Configuration reports as available to upgrade, so I can re-gain my lost traffic that comes from Disqus conversations.
Comment #22
slashrsm commentedSee https://www.drupal.org/patch/apply to learn how to apply patches. It is not safe to commit and release this change until I get proper feedback. Help from everybody key to everybody's success. It is how free software works.
Comment #23
Mark_L6n commentedI tried the patch from #8, after running the patch at https://www.drupal.org/node/2508561#comment-10060446.
However, I received an error message.
What I ran:
patch -p1 --dry-run < 2505743_8.patchResponse:
However, I am not able to find a file
disqus.module.rej.Comment #24
slashrsm commentedRerolled #8.
Comment #25
Mark_L6n commentedOK, tried new patch—long story :/
I restarted with a local copy of the site that was still on disqus 7.x-1.10.
2508561_10.patch:
2505743_24.patch:
So then I upgraded Disqus to version 7.x-1.12
2508561_10.patch and 2505743_24.patch upgraded without error messages.
Looking around my site, I get the error message, on pages that display Disqus:
Notice: Undefined index: status in disqus_node_view() (line 251 of /path/to/drupal/sites/all/modules/disqus/disqus.module).Don't see other errors.
Comment #26
slashrsm commented@Mark_L6n: Thank you for your review. This helps us a lot to get this patch committed asap. Patches should be tested with -dev version of the module unless stated otherwise. Can you try again using that version?
Comment #27
Mark_L6n commentedWhat steps do you recommend, starting at disqus 7.x-1.10?
drush @alias up disqus-7.x-1.x-dev? (or should I update first to 7.x-1.12?)Which patches? 2508561_10.patch and 2505743_24.patch, or just 2505743_24.patch ?
Comment #28
slashrsm commentedI'd say that you stay on 7.x-1.10 for now and wait for next release. I am planning to tag it as soon as we resolve this issue, #2438717: Default status per node is broken for existing nodes and #2508749: Programmatic status updates (almost) impossible. Any help with pushing them forward is appreciated.
Comment #29
CriticalBlast commentedMark_L6n, I would stay at 7.1.10 until the newest release is out. I'm at 7.1.12, and it still has its own issues with displaying Disqus (i.e. that it doesn't).
Comment #30
gippy commentedThis only occurs when saving an edit on node types which are NOT selected in the Visibility and Default Options tab of admin/config/services/disqus. The error does not appear when saving an edit on a node type for which Disqus is enabled.
7.x-1.x-dev with #8 patch return the following error four times:
Notice: Undefined index: title in disqus_node_update() (line 384 of /Users/mark/Sites/truthunity.local/core/sites/all/modules/contrib/disqus/disqus.module).
for 7.x-1.12 the error is:
Notice: Undefined index: title in disqus_node_update() (line 366 of /Users/mark/Sites/truthunity.local/core/sites/all/modules/contrib/disqus/disqus.module).
It appears that line 366 of the 7.x.-1.12 version does not bypass nodes that should not display Disqus.
I tried going back to 7.x-1.10. The same behavior happens, except that the error is:
Notice: Undefined property: stdClass::$disqus in disqus_node_update() (line 332 of /Users/mark/Sites/truthunity.local/core/sites/all/modules/contrib/disqus/disqus.module).
But the behavior changes with 7.x-1.x-dev with #24: viewing any node for which the node type is enabled will return:
Notice: Undefined index: status in disqus_node_view() (line 259 of /Users/mark/Sites/truthunity.local/core/sites/all/modules/contrib/disqus/disqus.module).
and viewing any node for which the node type is not enabled with not return any error.
Comment #31
PascalAnimateur commentedWrong variable name used in disqus_node_load when determining the default_disqus_status.
Here's a patch that works for me.
Comment #32
slashrsm commented#24 with this small tweak fixes problem on my sites.
Comment #33
amme commentedCan confirm patch in #32 works
Comment #34
amme commentedComment #40
slashrsm commentedCommited to 7.x-1.x. Will stay in -dev for a while so people can test before we do the release.
Thanks to all who contributed.
Comment #42
manuel garcia commentedIt seems like everyone updating the module to the latest version is going to get its comments disabled on all nodes unless:
1. You re-save the options form on /admin/config/services/disqus
2. You edit every node on the site and re-enable disqus comments (not a realistic options on most cases).
I have tested briefly on my local environment upgrading to the dev version of the module, seems to do the trick.
Any updates on this? Can we make a new release?
Comment #43
manuel garcia commentedComment #44
manuel garcia commented