Problem/Motivation

SSO login window doesn't close itself, instead gives a page not found error for /disqus/closewindow.

Proposed resolution

Use _controller instead of _content in disqus.routing.yml. Change record: https://www.drupal.org/node/2378809

'js' can no longer be used in '#attached'. Use library instead or find an alternate solution for using 'window.close()'.

Remaining tasks

None

User interface changes

None

API changes

None

CommentFileSizeAuthor
#5 interdiff-4-5.txt1.93 KBlammensj
#5 2482091-5.patch2.3 KBlammensj
#4 interdiff.txt963 bytesDylan Donkersgoed
#4 2482091-4.patch2.68 KBDylan Donkersgoed
#3 2482091-3.patch2.48 KBlammensj
#1 2482091-1.patch3.02 KBJayeshSolanki
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

JayeshSolanki’s picture

JayeshSolanki CreditAttribution: JayeshSolanki commented
Status: Active » Needs review
FileSize
2482091-1.patch3.02 KB

Attached a patch which fixes the issues. The patch uses 'html_head' instead of a separate file to attach the close window script.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented

You really shouldn't use "click here" as the text on a link, you'd be better off doing something like this:

Please <a href="!clickhere">close this window</a>.

lammensj’s picture

lammensj CreditAttribution: lammensj at iO commented
FileSize
2482091-3.patch2.48 KB

Rerolled the patch against the stable version.

Dylan Donkersgoed’s picture

Dylan Donkersgoed CreditAttribution: Dylan Donkersgoed at Northern Commerce commented
FileSize
2482091-4.patch2.68 KB
interdiff.txt963 bytes

Re-rolled this again for fe7cbd68bdf036cc2850ac8a06e736b1022f3383.

lammensj’s picture

lammensj CreditAttribution: lammensj at iO commented
FileSize
2482091-5.patch2.3 KB
interdiff-4-5.txt1.93 KB

Use of the "!"-placeholder in TranslatableMarkup is forbidden.

Chris Matthews’s picture

Chris Matthews CreditAttribution: Chris Matthews commented
Status: Needs review » Reviewed & tested by the community

The 2 year old patch in #5 to DisqusController.php and DisqusCommentManager.php applied cleanly to the latest disqus 8.x-1.x-dev and now looks RTBC worthy to me.

Applied patch src/Controller/DisqusController.php cleanly.
Applied patch src/DisqusCommentManager.php cleanly.

  • lammensj authored 028181f on 8.x-1.x 
    Issue #2482091 by lammensj, Dylan Donkersgoed, JayeshSolanki: SSO login...
gaurav.kapoor’s picture

gaurav.kapoor CreditAttribution: gaurav.kapoor at Axelerant for Drupal India Association commented

Pushed as well as fixed CS. Thanks for working on this.

gaurav.kapoor’s picture

gaurav.kapoor CreditAttribution: gaurav.kapoor at Axelerant for Drupal India Association commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.