Support from Acquia helps fund testing for Drupal Acquia logo

Comments

JayeshSolanki’s picture

Added support for disqus_disable_mobile:
https://github.com/angrycodr/disqus-for-drupal8/pull/20

JayeshSolanki’s picture

Status: Active » Needs review
slashrsm’s picture

Status: Needs review » Needs work

disqus_disable_mobile looks ok. disqus_category_id still needs to be implemented.

  • JayeshSolanki committed 5c3e16e on 8.x-1.x
    Issue #2304167: Implemented support for disqus_disable_mobile.
    
JayeshSolanki’s picture

I see two ways in which we can implement disqus_category_id (https://help.disqus.com/customer/portal/articles/1261676-using-categories)

1. We create categories (using api) according to the bundle name of the entity to which the disqus field is present. Adding disqus_category_id as field-level setting and all the field instance to this entity will have the same category.
(For eg. for content type 'article', the disqus category will be article).
Since creating categories require disqus api, this method would be an advantage as fewer api calls will be required and also it would much simpler to understand that disqus[category] = entity[bundle]

2. We give a field instance option 'category' while creating or editing an entity. the user will specify a category( sports, politics,etc), so it gives a bit of flexibility in categorizing comment. But why give the site's user the trouble to specify a comment category seperately ? Also there is no real implementation or any widget provided by disqus related to disqus_category_id, maybe in future we can provide views in drupal filtering with disqus categories.

First method seems better; wont be providing any form element for it. On field creation, just calling the api method categories->create on the bundle name string. The category will remain default 'General' if api is not installed.

JayeshSolanki’s picture

Status: Needs work » Needs review

pull request for implementing disqus_category_id according to the first method as I stated above :

https://github.com/angrycodr/disqus-for-drupal8/pull/35

slashrsm’s picture

Status: Needs review » Needs work

Few comments.

JayeshSolanki’s picture

FileSize
4.4 KB

this page no longer lists disqus_disable_mobile. Maybe we should remove it too.

slashrsm’s picture

Status: Needs work » Reviewed & tested by the community

#8 looks good.

kopeboy’s picture

Any news on Disqus categories?!
(I am interested in Drupal 7 atm..)

slashrsm’s picture

This is D8 feature only. Any patches for D7 are very welcome.

slashrsm’s picture

Status: Reviewed & tested by the community » Needs work

It would be great to have a patch from the pull request in #8.

  • JayeshSolanki authored cd8c9c1 on 8.x-1.x
    Issue #2304167 by JayeshSolanki: Implement support for...
gaurav.kapoor’s picture

Title: Implement support for disqus_category_id and disqus_disable_mobile » Remove usage of disqus_disable_mobile as it isn't supported anymore.
Status: Needs work » Needs review
gaurav.kapoor’s picture

Status: Needs review » Fixed

I have modified the scope of this issue and removed the settings and feature-related mobile optimized version. Thanks everyone for working on this.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.