Problem/Motivation

Following #3557112

The buildSingleBlock method needs some testing to be sure it's working as epxected.

Issue fork display_builder-3557196

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mogtofu33 created an issue. See original summary.

pdureau’s picture

pdureau commented
Assigned: Unassigned » pdureau

I will try to do it

pdureau’s picture

pdureau commented
Title: BuilderPanel: buildSingleBlock logic and tests » Add tests for BuilderPanel::buildSingleBlock()
Status: Active » Needs work

started

pdureau opened merge request !161

pdureau’s picture

pdureau commented
Assigned: pdureau » mogtofu33
Status: Needs work » Needs review
mogtofu33’s picture

mogtofu33 commented
Status: Needs review » Needs work

Current coverage by the test is :

 
Code Coverage
 
Lines
Branches
Paths
Functions and Methods
Classes and Traits
 buildSingleBlock
81.08% covered (warning)
81.08%
30 / 37
70.37% covered (warning)
70.37%
19 / 27
0.43% covered (danger)
0.43%
3 / 701
0.00% covered (danger)
0.00%
0 / 1
 268.73

Need a bit more work to cover everything and be confident in refactoring.

As well we should do the tree and layers tests which are lighter.

pdureau’s picture

pdureau commented
Assigned: mogtofu33 » pdureau

Once Jean has shared the cover HTML file, let's have a look:

  • if doable today, lets keep in beta1
  • if not, let"s move to beta2
mogtofu33’s picture

mogtofu33 commented

What's missing in coverage: here

pdureau’s picture

pdureau commented
Assigned: pdureau » mogtofu33
Status: Needs work » Needs review

I have added the 2 test cases I was able to add.

Only line 190 & 199 may not be covered, but another mechanism is preventing buildSingleBlock() to be reached (which is is good thing in my opinion)

mogtofu33’s picture

mogtofu33 commented
Assigned: mogtofu33 » Unassigned
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • mogtofu33 committed c6aa7b0f on 1.0.x authored by pdureau 
    test: #3557196 Add tests for BuilderPanel::buildSingleBlock()

By:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.