Let's check but it seems that ApiController::saveInstanceAsPreset() doesn't save:

  • third party settings (like the ones from UI Styles panel): no error but the info may be missing from saved preset (or missing when drop the preset)
  • field sources: Typed property Drupal\ui_patterns\SourcePluginBase::$propDefinition must not be accessed before initialization

Issue fork display_builder-3544543

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

pdureau created an issue. See original summary.

pdureau’s picture

pdureau commented
Issue tags: +display_builder-1.0.0-beta
mogtofu33’s picture

mogtofu33 commented
Assigned: Unassigned » mogtofu33
Status: Active » Needs work
mogtofu33’s picture

mogtofu33 commented
Assigned: mogtofu33 » Unassigned
Status: Needs work » Needs review

Seems ok, to be tested by someone else.

pdureau’s picture

pdureau commented
Assigned: Unassigned » pdureau

i take it :)

pdureau’s picture

pdureau commented
Assigned: pdureau » mogtofu33
Status: Needs review » Needs work

No MR and nothing pushed on git@git.drupal.org:issue/display_builder-3544543.git/display_builder-3544543 so i have tested on 1.0.X

third party settings (like the ones from UI Styles panel): no error but the info may be missing from saved preset (or missing when drop the preset)

Still KO

field sources: Typed property Drupal\ui_patterns\SourcePluginBase::$propDefinition must not be accessed before initialization

Still KO.

mogtofu33’s picture

mogtofu33 commented
Assigned: mogtofu33 » Unassigned
Status: Needs work » Active

Couldn't reproduce in the playwright tests, so was hopeful.
Back to active for someone to fix this.

pdureau’s picture

pdureau commented
Assigned: Unassigned » pdureau

i will have a look

pdureau opened merge request !112

pdureau’s picture

pdureau commented
Status: Active » Needs work
Issue tags: -display_builder-1.0.0-beta +display_builder-1.0.0-beta1

it is going well

pdureau’s picture

pdureau commented

Error: Typed property Drupal\ui_patterns\SourcePluginBase::$propDefinition must not be accessed before initialization in Drupal\ui_patterns\SourcePluginBase->getPropDefinition() (line 333 of modules/custom/ui_patterns/src/SourcePluginBase.php. will be addressed in UI Patterns side: #3545508: Property access error in DerivableContextSourceBase->calculateDependencies()

pdureau’s picture

pdureau commented
Assigned: pdureau » mogtofu33
Status: Needs work » Needs review
mogtofu33’s picture

mogtofu33 commented
Assigned: mogtofu33 » pdureau
Status: Needs review » Needs work
pdureau’s picture

pdureau commented
Assigned: pdureau » mogtofu33
Status: Needs work » Needs review

  • mogtofu33 committed cf80bf31 on 1.0.x authored by pdureau 
    [#3544543] feat: Some presets are not saved correctly

By: pdureau
pdureau’s picture

pdureau commented
Assigned: mogtofu33 » Unassigned
Status: Needs review » Fixed

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.