Problem/Motivation

DisplayBuilder class is massive (660 lines including 380 PHP lines).

Some entity types have a view_builder handler to move the rendering logic into a dedicated class. Example:

  handlers: [
    'storage' => NodeStorage::class,
    'view_builder' => NodeViewBuilder::class,
    'access' => NodeAccessControlHandler::class,

Proposed resolution

Let's do the same.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

pdureau created an issue. See original summary.

pdureau’s picture

Assigned: Unassigned » pdureau
Status: Active » Needs work

Done & pushed, but we need to wait some other tasks to finish:

pdureau’s picture

Let's not forget to also update the graphs in the documentation.

pdureau’s picture

pdureau’s picture

Assigned: pdureau » mogtofu33
Status: Needs work » Needs review

mogtofu33 made their first commit to this issue’s fork.

  • mogtofu33 committed e32bf7cf on 1.0.x
    #3542000 fix: split DisplayBuilder logic into a view_builder handler
    
mogtofu33’s picture

Assigned: mogtofu33 » Unassigned
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.