Context management for Pattern presets

Work in progress.

PatternPreset::hasContextsRequirement() is not done yet.

Hi Jean,

Ready for review. Tested with entity view, page layout & dev tools. Tested with slots sources, props sources, nested components. All looks good.

I have also did another change in the MR: printing the label of the theme instead of the machine name in Patterns entity list builder.

There are some playwright fails but i have different results locally so i am not sure it is related to the current MR: https://git.drupalcode.org/project/display_builder/-/jobs/6555885

There will be a follow-up issue for a very specific complementary task: #3546964: Better context management in presets

Can you confirm this problem? I guess it's more an api controller problem,

Thanks a lot. I will have a look

Seems to work fine, as a detail I always got 'Entity' as context even if it's a preset without any context (created from devel instance for example). Which seems strange.

I am not able to reproduce this problem.

From /admin/structure/page-layout/test/builder

• A card with page title in slot >> ✅ Page context
• Just a button >> ✅ No context

From /admin/structure/types/manage/article/display/default/display-builder

• A card with node title in slot >> ✅ Entity context
• A button with entity link in prop >> ✅ Entity context
• Just a button >> ✅ No context

From /admin/structure/display-builder/instance/devel__68cafe0e946b3

• Just a button >> ✅ No context

Then I see that the PatternPreset::getContexts() is called each time the library of presets is loaded for each preset (even the non compatible ones).
It seems expensive, could the contexts be stored on the entity the first time and when edited only? So it can be cached. I tested with full entity cache to ensure it was not cached anywhere.

I will try.

An other unrelated issue that I thought was fix is the preset not persisting in the builder (tested without cache this time):
Create a preset, add the preset to the builder: it's rendered, history added, preset added to logs! But then click it and the instanceform will be empty. Refresh and the preset is not here anymore, with no logs...
Can you confirm this problem? I guess it's more an api controller problem,

Indeed, I am reproducing this issue.

I am not able to save the calculated contexts to config (in order to avoid recalculating them all the time) because of:

Uncaught PHP Exception Drupal\Core\Config\UnsupportedDataTypeConfigException: "Invalid data type for config element display_builder.pattern_preset.68d594d360b6d:contexts.context_requirements" at /home/pierre/Projects/Drupal/ui_patterns_2/web/core/lib/Drupal/Core/Config/StorableConfigBase.php line 202

What do we do? We merge like that, we ask UIP2 team to fix something and we continue in later beta?

That's strange from fresh install I still have the entity context even with no context in the preset. Tested with db_theme_test and component test_simple.

I will test with the same theme and component.

That's strange from fresh install I still have the entity context even with no context in the preset. Tested with db_theme_test and component test_simple.

I am not reproducing this.

This pattern preset has no contexts detected:

source_id: component
source:
  component:
    component_id: 'display_builder_theme_test:test_simple'

The entity context is added by token source. Let's create a UIP2 issue about that.

Create a preset, add the preset to the builder: it's rendered, history added, preset added to logs! But then click it and the instanceform will be empty. Refresh and the preset is not here anymore, with no logs...

I will check if I have this in 1.0.x branch.

With your additional commit, I don't have this anymore:

Create a preset, add the preset to the builder: it's rendered, history added, preset added to logs! But then click it and the instanceform will be empty. Refresh and the preset is not here anymore, with no logs...

Follow-up in UIP2: #3549567: TokenSource::getContextDefinitions() always return entity