Problem/Motivation

FILE: .../web/modules/contrib/diff_moderate/src/Plugin/views/field/DiffModerate.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AND 3 WARNINGS AFFECTING 4 LINES
--------------------------------------------------------------------------------
21 | WARNING | [ ] t() calls should be avoided in classes, use
| | \Drupal\Core\StringTranslation\StringTranslationTrait and
| | $this->t() instead
31 | WARNING | [ ] Unused variable $rev_key.
33 | WARNING | [ ] Line exceeds 80 characters; contains 87 characters
43 | ERROR | [x] Missing function doc comment
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: ...es/contrib/diff_moderate/src/Controller/NodeModerateRevisionController.php
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------
40 | WARNING | Line exceeds 80 characters; contains 92 characters
--------------------------------------------------------------------------------

Time: 293ms; Memory: 10MB

Steps to reproduce

Execute the command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,js,info,txt,md,yml,twig diff_moderate/

Proposed resolution

Resolve all the issues for Drupal and DrupalPractice coding standards

Remaining tasks

Patch review.

CommentFileSizeAuthor
#5 after patch.png166.99 KBparaderojether
#5 before patch.png218.21 KBparaderojether
#4 3353940-After-Patch.png422.17 KBrassoni
#4 3353940-Before-Patch.png1.39 MBrassoni
coding_standard_fixes.patch2.21 KBurvashi_vora

Issue fork diff_moderate-3353940

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

urvashi_vora created an issue. See original summary.

Rassoni made their first commit to this issue’s fork.

Rassoni opened merge request !1

rassoni’s picture

rassoni commented
StatusFileSize
new 3353940-Before-Patch.png1.39 MB
new 3353940-After-Patch.png422.17 KB

Review patch and tested locally. Mention all phpcs issues are resolved. RTBC +

paraderojether’s picture

paraderojether commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new before patch.png218.21 KB
new after patch.png166.99 KB

Hi Rassoni,

I also reviewed MR!1, applied against Moderate diff 1.0.x-dev with Drupal core version 10.1.7, and confirmed it fixes the issue reported by phpcs.

I added screenshots for reference.
Thank you.