Summary:

When i was checking the review of a content i got this error message once i press backward button

Warning: Undefined array key "undefinedasync" in Drupal\diff\Controller\PluginRevisionController->buildLayoutNavigation() (line 205 of modules/contrib/diff/src/Controller/PluginRevisionController.php).
Drupal\diff\Controller\PluginRevisionController->buildLayoutNavigation(Object, '8325', '8329', 'undefinedasync') (Line: 161)
Drupal\diff\Controller\PluginRevisionController->compareEntityRevisions(Object, Object, Object, 'undefinedasync') (Line: 49)
Drupal\diff\Controller\NodeRevisionController->compareNodeRevisions(Object, Object, Object, 'undefinedasync')
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 580)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)

Go to any existing content 'node' and compare two revisions then pressing backward you should
see the error

CommentFileSizeAuthor
#3 3372506.patch733 byteseyad alanati

Comments

eyad alanati created an issue. See original summary.

eyad alanati’s picture

eyad alanati commented
Issue summary: View changes
eyad alanati’s picture

eyad alanati commented
StatusFileSize
new 3372506.patch733 bytes

I've made this patch and i wonder if it works ok!

eyad alanati’s picture

eyad alanati commented
Status: Active » Needs review
abdelraheim’s picture

abdelraheim commented

works fine for me

oalqteby17’s picture

oalqteby17 commented

work as a charm

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Version: 8.x-1.1 » 2.x-dev

For this to be reviewed and accepted, please review https://git.drupalcode.org/project/diff#contribution-guidelines. Since this is an older contribution, it might need a reroll/rebase. Additionally, we'll need an MR opened and some tests.

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Status: Needs review » Needs work
acbramley’s picture

acbramley commented
Status: Needs work » Postponed (maintainer needs more info)

I am unable to reproduce this bug with the small amount of information here.

Can you please provide detailed steps on how to reproduce this issue? If these are not provided within 3 months this issue may be closed.