Show moderation control form on diffs between latest published and current draft workflow states [#3335901]

Problem/Motivation

The most relevant view when a moderator is reviewing content oftentimes will be the one that shows the changes from most recently proposed new version compared to the currently published revision.

For example, if a long piece of content were approved, and then a one-character change were made to it, it's almost useless to review the full content versus some version of what diff module can provide, so the moderation control form should be available on diffs revisions.

Steps to reproduce

If you enable the "Moderation control" pseudofield, you can see the form when viewing the latest revision at a path like this: /node/3816/revisions/8856/view

Approve, Log message textbox, and Apply button

But there is no way to make the Moderation control form show on the display of changes that the diff module can provide at a path like this: /node/3816/revisions/view/8636/8856/visual_inline

dates.

Proposed resolution

Provide a tab or other link that pre-selects the diff between the published version and the draft/in-review version (unless something already does this?)
Show the moderation control form on this diff page

Remaining tasks

Confirm nothing is doing either of these steps, decide how to implement them, and implement them.

User interface changes

Moderation control form is visible on the latest draft revision vs latest published revision page; some helper link to this page somewhere.

API changes

Probably none?

Data model changes

None.

Comment	File	Size	Author
#4	example-diff-moderate-in-operation.png	78.63 KB	mlncn
	diff-module-diff.png	39.21 KB	mlncn
	moderation-control-form.png	40.88 KB	mlncn

Comments

Comment #1

23 January 2023 at 17:41

mlncn created an issue. See original summary.

Comment #2

mlncn commented 23 January 2023 at 23:52

If/when #2875843: Display content moderation form on published revisions gets in, we would want this form on the additional relevant diffs analogous to the revision pages outlined there.

Comment #3

mlncn commented 24 January 2023 at 11:59

Status:

Active

» Needs review

Made a module as a proof of concept for this, would appreciate Diff module maintainer feedback on if it should/could become part of diff:

https://www.drupal.org/project/diff_moderate

Presently the main rough edge in my view is there cannot be a link to a diff if there has not yet been a published revision, so in those cases it falls back to linking to the latest revision, on the presumption that the Content Moderation form is enabled there as Drupal core allows and so provides an analogous experience.

(This link is provided as a views field plugin; there is not currently any other way to get to the revisions/moderate/ page other than URL hacking… probably it could also be a tab.)