Made a code wise translatable string review. Patch attached.

CommentFileSizeAuthor
#4 Issue-2872110-by-hass-Translatable-string-review.patch7.46 KBhass
#2 Issue-2872110-by-hass-Translatable-string-review.patch7.46 KBhass
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hass created an issue. See original summary.

hass’s picture

hass CreditAttribution: hass commented
Status: Active » Needs review
FileSize
Issue-2872110-by-hass-Translatable-string-review.patch7.46 KB

Status: Needs review » Needs work

The last submitted patch, 2: Issue-2872110-by-hass-Translatable-string-review.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

hass’s picture

hass CreditAttribution: hass commented
Status: Needs work » Needs review
FileSize
Issue-2872110-by-hass-Translatable-string-review.patch7.46 KB

Status: Needs review » Needs work

The last submitted patch, 4: Issue-2872110-by-hass-Translatable-string-review.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

hass’s picture

hass CreditAttribution: hass commented
Status: Needs work » Needs review

not my fault.

15:37:37 Fatal error: Call to a member function getTypePlugin() on a non-object in /var/www/html/modules/contrib/diff/src/Tests/DiffRevisionContentModerationTest.php on line 28
15:37:38 FATAL Drupal\diff\Tests\DiffRevisionContentModerationTest: test runner returned a non-zero error code (255).