Paragraph always changed in revision summary

Yes, debugging a bit realized that that happens because when a new revision is created of the host entity, the paragraphs also create a new revision so the reference is updated and the paragraphs field appear in the revision summary.

Being trying this but since the revision reference is updated and so, we would need to load the entity that is referenced and also the revision that was referenced to the previous host entity. Wouldn't the performance be affected with this? it would be like building the whole array for comparing in the revision listing and with all the revisions doing the same. Not really sure.

Early patch. Tried for long time. Patch loops over the fields inside the entity. Right now broken cause sometimes we can add a Paragraph in a revision so the summary is not generated correctly. Need to investigate more.

Actually this makes it more readable.

Let's see now. :) Interdiff added.

Added screenshot.
When a new paragraph is added the name of the field of the host entity is displayed, when the fields inside a Paragraph are updated the name of the fields in the Paragraphs are shown.

Actually this can be much cleaner, I'm trying something now. Will upload a patch soon.

Worked on this, but this makes me realize that loading the entity that a node was pointing and load the revision of the pointed revision and then comparing might be harder than expected.

OK, discussed with Miro, we will use the EntityParser code to make it recursive and nice for the user. :)

Started from 0. Now we have a better display of the changed fields.

I was wondering if the initial revision should have a comment like "Initial revision." instead of "No changes." That would be much nicer IMO.

Ups, just realized there are some small problems when an entity is present in one revision and not in the other one, still needs work.

This should work nicer. And also test fixed.
Looks like this now:

EDIT: Wrong comment.

Small small re-considerations:

1. +++ b/src/DiffEntityComparison.php
   @@ -268,15 +268,57 @@ class DiffEntityComparison {
   +    // Check if the revision has a revision log, if not the auto generate it.
   

   I would say this
   // Check if the revision has a log message.
   and
   // Auto generate a revision log.
   above the if ($auto_generated)

2. +++ b/src/DiffEntityComparison.php
   @@ -268,15 +268,57 @@ class DiffEntityComparison {
   +    }
   +    if ($auto_generated) {
   

   Then would add a new line.

3. +++ b/src/DiffEntityComparison.php
   @@ -268,15 +268,57 @@ class DiffEntityComparison {
   +      // If there is a previous revision, load the values of each and add to the
   +      // summary the ones that have changed.
   

   Not sure what you meant, but maybe
   // If there is a previous revision, load its values and add the changed
   // ones to the summary.

4. +++ b/src/DiffEntityComparison.php
   @@ -268,15 +268,57 @@ class DiffEntityComparison {
   +          // If the field is present in the left entity, compare values, if not
   +          // add it to the summary. Unset the ones already added.
   

   
   // Unset the field, which value is not changed. Add it to the summary
   // if it is changed or new.
   

5. +++ b/src/DiffEntityComparison.php
   @@ -268,15 +268,57 @@ class DiffEntityComparison {
   +          if (isset($left_values[$key])) {
   +            if ($value != $left_values[$key]) {
   +              $revision_summary[] = $value['label'];
   +            }
   +            unset($left_values[$key]);
   +          }
   +          else {
   +            $revision_summary[] = $value['label'];
   +          }
   

   And I would shorten this check as

   if (isset($left_values[$key]) && ($left_values[$key] != $value)) {
      unset($left_values[$key]);
   }
   else {
       $revision_summary[] = $value['label'];
   }
   

6. +++ b/src/DiffEntityComparison.php
   @@ -268,15 +268,57 @@ class DiffEntityComparison {
   +        // Loop over the left values that remain and add them if not present in
   +        // the right entity.
   

   // Add the remaining left values not present in the right entity..

   And separate this foreach-block from the one above.

7. +++ b/src/DiffEntityComparison.php
   @@ -285,31 +327,36 @@ class DiffEntityComparison {
   +     $result = array();
   

   []

Comments changed.
5. of the comment above cannot be done, that would mean change in the logic, after comparing a field no matter it has changed or not, if present in the right side, I unset it, so just remaining fields are added when looping on the left values.

This might change when #2810039: Diff for 'Sticky at top of lists' does not work is committed. Will need to check again after that one is committed.

This should be nicer and more readable. :)

Much better IMHO.