This module does quite a lot, it turns out. It'd be great if there were tests to figure out if everything is working properly.

I'll try and document test cases as I find them here. Reviewing this module as part of #2325607: [meta] Get DMU working on Diff module.

Diff compare widgets

Revisions list w/ Diff

  • testRevisionsList — go to node/%node/revisions/list and verify diff output is on page.

Diff comparison

Revisions comparison w/ Diff

  • testRevisionsCompare — go to node/%node/revisions/view and verify diff comparison between 2 disparate revisions shows up.
  • testRevisionsLatest — go to node/%node/revisions/view/latest and verify that diff comparison against latest revision is shown

Diff admin settings

Diff admin menu item
Diff main settings form

  • testDiffSettings — go to admin/config/content/diff and verify that main settings form is working properly.

Diff entity settings form

  • testDiffSettingsNodeEntity — go to admin/config/content/diff/entities/node and verify settings form is working properly.
  • testDiffSettingsUserEntity — (not pictured) go to admin/config/content/diff/entities/user and verify settings form is working properly.

Diff Fields overview form
Diff Field settings form

Inline differences block

'Inline Differences' block in block listing
Block config page
Differences showing inline

  • testDiffBlock — Make sure block shows up in block listing at admin/structure/block, verify it shows up on content types selected.
  • testInlineDiff — (??? — not sure if this can be tested w/ SimpleTest). Test that changes are correctly highlighted when selecting revisions from block.

Diff buttons

View changes button
Diff shown at top of node form

  • testViewChanges — verify that "View changes" button shows up on node edit form, shows diff at top when clicked.

Node type form settings

Compare revisions vertical tab on node type form

  • testDiffSettingsNodeType — verify that Compare revisions options are working on e.g. Page.

Diff entity display

Entity display mode

  • testDiffDisplayMode — Go to admin/structure/types/manage/page/display, expand "Custom display settings, verify "revision comparison" shows up as a selectable view mode.

If someone feels exceptionally spunky

  • testLimitedItems — verify that REVISION_LIST_SIZE is working properly.
  • testExposedSorting — verify that diff sorting is working properly: DIFF_SORT_NONE, DIFF_SORT_VALUE, DIFF_SORT_CUSTOM.
  • testHelpText — test that help text is exposed where it should be (admin/help/diff, node/%/revisions/%/view, node/%/revisions/view/%/%
  • testDiffStates — test diff states (raw (Standard) / raw_plain (Marked down)
  • testRevisionAdminTheme — tests that revisions pages are shown in admin theme
  • testContentTypeRename — tests that when you rename a content type, all settings are remembered.
  • testContentTypeDelete — tests that when you delete a content type, all settings are deleted.
  • testDiffUsers — tests that diff features also work on users.
CommentFileSizeAuthor
#9 diff.test.diff4.41 KBwebchick
#4 Screen Shot 2014-08-26 at 4.14.02 PM.png53.44 KBwebchick
#3 Screen Shot 2014-08-26 at 4.10.29 PM.png32.71 KBwebchick
#3 Screen Shot 2014-08-26 at 4.09.43 PM.png16.87 KBwebchick
#3 Screen Shot 2014-08-26 at 4.04.23 PM.png38.16 KBwebchick
#3 Screen Shot 2014-08-26 at 4.01.20 PM.png50.25 KBwebchick
#3 Screen Shot 2014-08-26 at 4.00.59 PM.png10.84 KBwebchick
#3 Screen Shot 2014-08-26 at 3.53.50 PM.png38.73 KBwebchick
#1 Screen Shot 2014-08-26 at 3.50.00 PM.png58.97 KBwebchick
#1 Screen Shot 2014-08-26 at 3.49.45 PM.png60.5 KBwebchick
#1 Screen Shot 2014-08-26 at 3.48.01 PM.png38.37 KBwebchick
#1 Screen Shot 2014-08-26 at 3.46.06 PM.png69.56 KBwebchick
#1 Screen Shot 2014-08-26 at 3.44.15 PM.png12.18 KBwebchick
#1 Screen Shot 2014-08-26 at 3.42.50 PM.png86.98 KBwebchick
#1 Screen Shot 2014-08-26 at 3.40.09 PM.png80.81 KBwebchick

Comments

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Issue summary: View changes
StatusFileSize
new Screen Shot 2014-08-26 at 3.40.09 PM.png80.81 KB
new Screen Shot 2014-08-26 at 3.42.50 PM.png86.98 KB
new Screen Shot 2014-08-26 at 3.44.15 PM.png12.18 KB
new Screen Shot 2014-08-26 at 3.46.06 PM.png69.56 KB
new Screen Shot 2014-08-26 at 3.48.01 PM.png38.37 KB
new Screen Shot 2014-08-26 at 3.49.45 PM.png60.5 KB
new Screen Shot 2014-08-26 at 3.50.00 PM.png58.97 KB

Here's what I have so far from reading through the code and taking screenshots as I discover things.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Issue summary: View changes

Formatting.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Issue summary: View changes
StatusFileSize
new Screen Shot 2014-08-26 at 3.53.50 PM.png38.73 KB
new Screen Shot 2014-08-26 at 4.00.59 PM.png10.84 KB
new Screen Shot 2014-08-26 at 4.01.20 PM.png50.25 KB
new Screen Shot 2014-08-26 at 4.04.23 PM.png38.16 KB
new Screen Shot 2014-08-26 at 4.09.43 PM.png16.87 KB
new Screen Shot 2014-08-26 at 4.10.29 PM.png32.71 KB

Moar stuffs.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Issue summary: View changes
StatusFileSize
new Screen Shot 2014-08-26 at 4.14.02 PM.png53.44 KB
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Issue summary: View changes
alan d.’s picture

alan d. commented

I actually wonder if "Inline differences block" is worth removing and creating a separate project for? Open to peoples opinions on this. It is one thing that I have never used, and it is one thing that is a bit problematic in terms of integration with other modules.

I am just stating this here so either to drop (maybe unrequired) or raise the priority (it is the bit that normally fails) depending on the answer :)

@webchick
Thanks for your mentoring here. I was letting the core structural changes to get done before starting to review things hard.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

Oh, I think that's a totally fair feature to drop, from a module POV. *I* personally like it being there because then we get Drupal Module Upgrader working for configurable blocks and JS/CSS. ;)

alan d.’s picture

alan d. commented

lol, lets keep it for the meantime then, but with the possible intent to either separate out into a sub-module or even another project latter.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Active » Needs review
StatusFileSize
new diff.test.diff4.41 KB

Here is the absolute most basic start. All it does is define a base class that does some of the boilerplate work (like creating a node with 3 revisions for each test), then defines a test method that:

1) Hits node/X/revisions and makes the Compare button exists
2) Submits the form with the Compare button to make sure there are no errors
3) Validates that the output on the diff comparison is what's expected
4) While we're in there any way, tests the next/previous difference links as well

This should hopefully give kind of an idea of what's needed here. I'm not sure how much further (if at all) I'll be able to take this, so uploading what I've got after an hour or two of copy/pasting a lot from modules/node/node.test. :)

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented

I just committed basic test coverage for 8.x in the current master port sandbox.

No configuration variation yet, but the default processes offered with default settings.
See #2422735: Provide basic test coverage

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs review » Closed (outdated)

Given the proximity of EOL for Drupal 7, marking this as won't fix. The likely final Drupal 7 release of diff has landed in https://www.drupal.org/project/diff/releases/7.x-3.5. If this is something still applicable to a more modern version of the module, feel free to re-open and post additional notes.