Change "This is the published revision"

Yep that is a bug ;)

We can probably conditionally show two messages here (if we have context to the [partial?] $node in $var). How about some of these?

This is the current revision.
This is the published revision.

Or

This is the current revision.
This is the current revision (unpublished).

i.e. about line 52, diff.theme.inc for an easy commit credit:

$message = $node->status ? t('This is the current revision.') : t('This is the current revision (unpublished).');

Cross-posted in #1785742: Diff module string review

Can we keep the "published" wording with the status check, please? Aside the green color should only shown if the revision is published... Like in workbench... We may have forward revisions there that are not yet published, but an older revision is published.

@hass - which option were you referring to? Option 2?

I updated the issue summary with these to make these easier to track.

Yes, Option 2

A not so simple patch for a simple string change!

Cloned node_revision_list() to allow us to insert a new status field into the query, fixed excessive calls to count($revision_list) and removed the redundant second call to node_revision_list().

Now where did those numbers come from... (node.vid as radio labels in screenshot above)

Slight error in the sql.

-  $result = db_query('SELECT r.vid, r.title, r.log, r.uid, n.vid AS current_vid, n.status AS status, r.timestamp, u.name FROM {node_revision} r LEFT JOIN {node} n ON n.vid = r.vid INNER JOIN {users} u ON u.uid = r.uid WHERE r.nid = :nid ORDER BY r.vid DESC', array(':nid' => $node->nid));
+  $result = db_query('SELECT r.vid, r.title, r.log, r.uid, n.vid AS current_vid, r.status AS status, r.timestamp, u.name FROM {node_revision} r LEFT JOIN {node} n ON n.vid = r.vid INNER JOIN {users} u ON u.uid = r.uid WHERE r.nid = :nid ORDER BY r.vid DESC', array(':nid' => $node->nid));

And this gives us

Regarding radios: #2068015: Radios missing. Theme issue that should not have been committed and has been reverted. :)

Writing an issue summary.

Pushed through :)

Thanks all