Problem/Motivation
It's confusing when viewing the node/%nid/revisions the current revision is highlighted in green and say's "This is the published revision." even if that node isn't published.
Proposed resolution
To change this text too:
Option One
All: "This is the current revision."
Option Two
Unpublished: "This is the current revision."
Published: "This is the published revision."
Option Three
Unpublished: "This is the current revision (unpublished)."
Published: "This is the current revision."
Other suggestions?
Remaining tasks
Select the best text option.
User interface changes
Current revision text on node comparison page.
API changes
None
Related Issues
#1785742: Diff module string review
Original report by gmclelland
It's confusing when viewing the node/%nid/revisions the current revision is highlighted in green and say's "This is the published revision." even if that node isn't published.
It should probably say "This is the current revision."
What do you think?
Comments
Comment #1
Alan D. CreditAttribution: Alan D. commentedYep that is a bug ;)
We can probably conditionally show two messages here (if we have context to the [partial?] $node in $var). How about some of these?
This is the current revision.
This is the published revision.
Or
This is the current revision.
This is the current revision (unpublished).
i.e. about line 52, diff.theme.inc for an easy commit credit:
Cross-posted in #1785742: Diff module string review
Comment #2
hass CreditAttribution: hass commentedCan we keep the "published" wording with the status check, please? Aside the green color should only shown if the revision is published... Like in workbench... We may have forward revisions there that are not yet published, but an older revision is published.
Comment #3
Alan D. CreditAttribution: Alan D. commented@hass - which option were you referring to? Option 2?
I updated the issue summary with these to make these easier to track.
Comment #4
hass CreditAttribution: hass commentedYes, Option 2
Comment #5
Alan D. CreditAttribution: Alan D. commentedA not so simple patch for a simple string change!
Cloned node_revision_list() to allow us to insert a new status field into the query, fixed excessive calls to count($revision_list) and removed the redundant second call to node_revision_list().
Now where did those numbers come from... (node.vid as radio labels in screenshot above)
Comment #6
Alan D. CreditAttribution: Alan D. commentedSlight error in the sql.
And this gives us
Comment #7
gmclelland CreditAttribution: gmclelland commentedThanks @Alan D. Your patch in #6 works for me. I tested with the node published and unpublished.
I haven't looked at the code, but those revision numbers might be coming from the https://drupal.org/project/revision_scheduler module?
Comment #8
Alan D. CreditAttribution: Alan D. commentedRegarding radios: #2068015: Radios missing. Theme issue that should not have been committed and has been reverted. :)
Comment #8.0
Alan D. CreditAttribution: Alan D. commentedWriting an issue summary.
Comment #10
Alan D. CreditAttribution: Alan D. commentedPushed through :)
Thanks all
Comment #11
Alan D. CreditAttribution: Alan D. commented