Currently this module does now allow outofpage adslots. Despite it being listed as a

// @todo Implement out_of_page setting like D7 module.

Patch supplied

CommentFileSizeAuthor
#5 3074344-out-of-page-adslot.patch10.29 KBleo_theo
Allow-out-of-page-adslots.patch4.25 KBau_dave

Issue fork dfp-3074344

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

au_dave created an issue. See original summary.

jedihe’s picture

jedihe commented
Parent issue: » #2660556: [plan] Finish port to Drupal 8
jedihe’s picture

jedihe commented
Status: Active » Closed (duplicate)

Found that a minor improvement to #2905255: Implement out_of_page setting like D7 module. #4 was enough to make tests pass again. Due to the other issue being older, I'm closing this as a duplicate.

jedihe’s picture

jedihe commented
Parent issue: #2660556: [plan] Finish port to Drupal 8 »
leo_theo’s picture

leo_theo commented
StatusFileSize
new 3074344-out-of-page-adslot.patch10.29 KB

I remade the patch for out of page adslots against 8.1.x

leo_theo opened merge request !1

jedihe’s picture

jedihe commented

@leo_theo: thanks for updating the patch!

Checking at the previous status update, I marked this specific issue as a duplicate of #2905255: Implement out_of_page setting like D7 module.. Would it be too hard to port this latest round of work to the other issue?

LeoJlt made their first commit to this issue’s fork.