The recent Drupal 8 port does not contain all of the functionality in the Drupal 7 version. This issue will be used to discuss the requirements and whether we need to support these features.
The missing features are:
- The ability to set targets using any taxonomies that appear on the page
- The ability to inject custom javascript
- A migration path from Drupal 7
- Prevent a tag from being used twice
- Adtest page
- Vertical tab styling for admin
- Out-of-page ads and context integration
- Token browser integration in the admin forms
The ability to set targets using any taxonomies that appear on the page
Looking at the feature in Drupal 7 this adds targets to a page if any taxonomy term of a selected vocabulary is viewed. The term's vocabulary has a field that allows the user to specify a target to be added if the taxonomy appears. The targets are also taxonomy terms and the link is made using a taxonomy reference field - the vocabulary is provided by the module.
The ability to inject custom javascript
The global settings in the Drupal 7 version have the ability to add JS to the page. This is likely to be extremely implementation specific - I'm (alexpott) not to keen on this feature since it's maintaining javascript code in the database - so we've got security issues and wrong tool for the job.
A migration path from Drupal 7
Should be pretty simple to set up.
Prevent a tag from being used twice
In the Drupal 7 version tags are prevented from appearing twice on a page. In Drupal 8 this issue is more sever because blocks can be placed twice. That said doing this does not create a bug - Google just doesn't serve the add.
Adtest page
The D7 version has a page where you can view all of the DFP tags at once.
Vertical tab styling in admin
D7 DFP uses vertical tabs everywhere in its administration screens - should we do this in D8?
Out-of-page ads and context integration
D7 could place ads out of the page and had context integration.
Just need to work out how the token browser works in D8 and use it.
Comments
Comment #2
alexpottComment #3
alexpottComment #4
bleen commentedJust to give some context about "The ability to set targets using any taxonomies that appear on the page"...
The general idea here is that content creators generally tag content for editorial reasons. They want to tag content in order to (for example) create taxonomy aggregation pages and/or to relate similar content.
As sales folks, on the other hand, want to package content for sale regardless of the editorial use-case. For example, he or she may want to create a package of content that includes sports articles and gossip articles and local news articles that all have to do with Derek Jeter because MLB wants to buy all Derek Jeter content. The content creators may not want to tag content that isn't in the sports section with Derek Jeter so now the two departments have competing interests ...
I realize that this was a bit long-winded, but that's the general use-case
Comment #5
damienmckennaI think this can be closed given there's a stable release available.